Orekit issueshttps://gitlab.orekit.org/groups/orekit/-/issues2023-12-30T11:41:37Zhttps://gitlab.orekit.org/orekit/orekit/-/issues/1277Regression in computation speed when using Ephemeris2023-12-30T11:41:37ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euRegression in computation speed when using EphemerisHi everyone,
Opening this issue following [this forum thread](https://forum.orekit.org/t/decreased-computation-speed-of-eventdetector-in-orekit-12-0/3097)
Working on it.
Cheers,
VincentHi everyone,
Opening this issue following [this forum thread](https://forum.orekit.org/t/decreased-computation-speed-of-eventdetector-in-orekit-12-0/3097)
Working on it.
Cheers,
Vincent12.0.1Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/issues/1276Replace use of multiply on Field one by newInstance2023-12-06T11:27:47ZRomain SerraReplace use of multiply on Field one by newInstancePerformance wise, using multiply with scalar on Fielded one is worse than using newInstancePerformance wise, using multiply with scalar on Fielded one is worse than using newInstance12.1Romain SerraRomain Serrahttps://gitlab.orekit.org/orekit/orekit/-/issues/1275Add utility class for (Field) position angle conversions2023-12-05T17:14:00ZRomain SerraAdd utility class for (Field) position angle conversionsKeplerian anomaly already has it, so do the same for circular and Equinoctial, it will make the (Field) Orbit classes more readableKeplerian anomaly already has it, so do the same for circular and Equinoctial, it will make the (Field) Orbit classes more readable12.1Romain SerraRomain Serrahttps://gitlab.orekit.org/orekit/orekit/-/issues/1274Use of Tide class in OceanTidesWaves2023-12-30T08:32:54ZGaëtan PierreUse of Tide class in OceanTidesWavesReplace `doodson`, `cGamma`, `cL`, `cLPrime`, `cF`, `cD`, `cOmega `by a `Tide`. In `addContribution`, replace `thetaF` computation by `getPhase` method.Replace `doodson`, `cGamma`, `cL`, `cLPrime`, `cF`, `cD`, `cOmega `by a `Tide`. In `addContribution`, replace `thetaF` computation by `getPhase` method.https://gitlab.orekit.org/orekit/orekit/-/issues/1273TimeSystem parsing in SP3Parser2024-02-06T12:48:06ZMark RuttenTimeSystem parsing in SP3ParserAn exception is thrown parsing sp3 ephemeris produced by the [qzss team](https://sys.qzss.go.jp/dod/en/archives/pnt.html). The time system in those files is "QZS", shown in the short extract below:
```text
++ 0 0 0 0 0 0 0...An exception is thrown parsing sp3 ephemeris produced by the [qzss team](https://sys.qzss.go.jp/dod/en/archives/pnt.html). The time system in those files is "QZS", shown in the short extract below:
```text
++ 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
%c M cc QZS ccc cccc cccc cccc cccc ccccc ccccc ccccc ccccc
%c cc cc ccc ccc cccc cccc cccc cccc ccccc ccccc ccccc ccccc
%f 1.2500000 1.025000000 0.00000000000 0.000000000000000
```
The time parsing section in `SP3Parser`
```java
final TimeSystem ts;
if (tsStr.equalsIgnoreCase("ccc")) {
ts = TimeSystem.GPS;
} else {
ts = TimeSystem.valueOf(tsStr);
}
```
could (should?) be changed to
```java
final TimeSystem ts;
if (tsStr.equalsIgnoreCase("ccc")) {
ts = TimeSystem.GPS;
} else {
ts = TimeSystem.parseTimeSystem(tsStr);
}
```
Further discussion on the [orekit forum](https://forum.orekit.org/t/timesystem-parsing-from-qzss-sp3/3076).12.0.2Mark RuttenMark Ruttenhttps://gitlab.orekit.org/orekit/orekit/-/issues/1272add converters AbsoluteDate from/to Instant2024-01-16T12:56:46ZSabrina Sarraadd converters AbsoluteDate from/to InstantIt would be useful to add methods to convert AbsoluteDate from/to Java Instant.
https://forum.orekit.org/t/absolutedate-to-java-instant/3090It would be useful to add methods to convert AbsoluteDate from/to Java Instant.
https://forum.orekit.org/t/absolutedate-to-java-instant/309012.1Christopher SchankChristopher Schankhttps://gitlab.orekit.org/orekit/orekit/-/issues/1271Add Intellij checkstyle configuration in contributing.md2023-12-30T11:41:58ZBryan CazabonneAdd Intellij checkstyle configuration in contributing.mdIt would be great to add Checkstyle configuration for Intellij in the contributing.md file.It would be great to add Checkstyle configuration for Intellij in the contributing.md file.12.0.1Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/1270Renaming in (Field) Propagator2023-11-16T07:43:09ZRomain SerraRenaming in (Field) Propagator`Propagator` has a `getEventsDetectors` method, which is not coherent with `getEventDetectors` in `EventDetectorProvider` (no S in the middle) and should thus be renamed.
Check Field version as well.`Propagator` has a `getEventsDetectors` method, which is not coherent with `getEventDetectors` in `EventDetectorProvider` (no S in the middle) and should thus be renamed.
Check Field version as well.https://gitlab.orekit.org/orekit/orekit/-/issues/1269Infinite loop when using specific date with CssiSpaceWeatherData2023-12-30T11:42:34ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euInfinite loop when using specific date with CssiSpaceWeatherDataHi everyone,
@MaximeJ noticed an infinite loop when using the ```CssiSpaceWeatherData``` at specific date.
Error can be reproduced using the following file:
[2023-11-14_-_Error_Infinite_Loop_CSSI.zip](/uploads/3a3d469880db4135a4db555d8...Hi everyone,
@MaximeJ noticed an infinite loop when using the ```CssiSpaceWeatherData``` at specific date.
Error can be reproduced using the following file:
[2023-11-14_-_Error_Infinite_Loop_CSSI.zip](/uploads/3a3d469880db4135a4db555d8a3ef88f/2023-11-14_-_Error_Infinite_Loop_CSSI.zip)
Cheers,
Vincent
EDIT:
Issue occurs when using date with month with 30 or less days in the predicted monthly data. A fix has been found and is currently under implementation.12.0.1Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/issues/1268Add Herrick-Gibbs IOD method2023-11-13T13:55:03ZRomain SerraAdd Herrick-Gibbs IOD methodGibbs' method suitability for closely spaced positions is limited. There's an alternative for that case, referred to as Herrick-Gibbs in Vallado's book (page 466 in 4th edition)Gibbs' method suitability for closely spaced positions is limited. There's an alternative for that case, referred to as Herrick-Gibbs in Vallado's book (page 466 in 4th edition)https://gitlab.orekit.org/orekit/orekit-tutorials/-/issues/27Update release-guide2023-11-10T11:27:07ZMaxime JournotUpdate release-guideFollowing the release of Tutorials 12.0 it appeared some information was outdated.Following the release of Tutorials 12.0 it appeared some information was outdated.12.1Maxime JournotMaxime Journothttps://gitlab.orekit.org/orekit/orekit-tutorials/-/issues/26License file not showing in Maven documentation2023-11-09T20:02:29ZMaxime JournotLicense file not showing in Maven documentationThe [license disclaimer](https://www.orekit.org/site-orekit-tutorials-development/licenses.html) for Apache Software License, v2.0 is missing.
It should be added automatically to the website like it is done in [Orekit technical docume...The [license disclaimer](https://www.orekit.org/site-orekit-tutorials-development/licenses.html) for Apache Software License, v2.0 is missing.
It should be added automatically to the website like it is done in [Orekit technical documentation](https://www.orekit.org/site-orekit-development/licenses.html).https://gitlab.orekit.org/orekit/orekit-tutorials/-/issues/25Update site page "Integration in other languages"2023-11-09T19:59:57ZMaxime JournotUpdate site page "Integration in other languages"Page [Integration in other languages](https://www.orekit.org/site-orekit-tutorials-development/tutorials/integration-in-other-languages.html) should be updated, preferably by someone who knows his way with Orekit in Matlab.Page [Integration in other languages](https://www.orekit.org/site-orekit-tutorials-development/tutorials/integration-in-other-languages.html) should be updated, preferably by someone who knows his way with Orekit in Matlab.https://gitlab.orekit.org/orekit/orekit/-/issues/1267Mixed up Javadoc for Orbit.getEquinoctialEx, getEquinoctialExDot, getEquinoct...2023-12-30T08:27:21ZClément JonglezMixed up Javadoc for Orbit.getEquinoctialEx, getEquinoctialExDot, getEquinoctialEy, getEquinoctialEyDotThe javadoc for the Orbit's `getEquinoctialEx` method for instance says the following, whereas this should rather apply to the `getEquinoctialExDot` method:
```
/** Get the first component of the equinoctial eccentricity vector deriv...The javadoc for the Orbit's `getEquinoctialEx` method for instance says the following, whereas this should rather apply to the `getEquinoctialExDot` method:
```
/** Get the first component of the equinoctial eccentricity vector derivative.
* @return first component of the equinoctial eccentricity vector derivative
*/
```
On the other hand, the first and fifth lines of `getEquinoctialExDot`'s method description rather belong to `getEquinoctialEx`:
```
/** Get the first component of the equinoctial eccentricity vector.
* <p>
* If the orbit was created without derivatives, the value returned is {@link Double#NaN}.
* </p>
* @return first component of the equinoctial eccentricity vector
* @see #hasDerivatives()
* @since 9.0
*/
```
The same apply for `getEquinoctialEy` vs `getEquinoctialEyDot`.
https://www.orekit.org/static/apidocs/org/orekit/orbits/Orbit.html#getEquinoctialEx--https://gitlab.orekit.org/orekit/orekit/-/issues/1266SpacecraftStateInterpolator constructor ignores extrapolation threshold2023-12-30T11:42:58ZChristopher SchankSpacecraftStateInterpolator constructor ignores extrapolation thresholdRegardless of which constructor is used, SpacecraftStateInterpolator will always use DEFAULT_EXTRAPOLATION_THRESHOLD_SEC
```
@Test
public void testConstructor() {
Frame gcrf = DataContext.getDefault().getFrames().getGCRF();
...Regardless of which constructor is used, SpacecraftStateInterpolator will always use DEFAULT_EXTRAPOLATION_THRESHOLD_SEC
```
@Test
public void testConstructor() {
Frame gcrf = DataContext.getDefault().getFrames().getGCRF();
SpacecraftStateInterpolator spacecraftStateInterpolator = new SpacecraftStateInterpolator(5, 7.0, gcrf, gcrf);
assertEquals(7.0, spacecraftStateInterpolator.getExtrapolationThreshold());
}
```
Edit: Orekit 12.012.0.1Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/issues/1265Improve coverage for 12.X versions2024-03-19T17:04:44ZMaxime JournotImprove coverage for 12.X versionsFollowing the release of 12.0, the coverage on new code, that was up to 95.2% on develop branch, inexplicably dropped to 94.8% when the merge on master branch was done.
See the list of uncovered lines [here](https://sonar.orekit.org/co...Following the release of 12.0, the coverage on new code, that was up to 95.2% on develop branch, inexplicably dropped to 94.8% when the merge on master branch was done.
See the list of uncovered lines [here](https://sonar.orekit.org/component_measures?branch=master&id=orekit%3Aorekit&metric=new_line_coverage).
And now the quality gate is on "warning" on Orekit's [official website](https://orekit.org)...
I think this should be fixed in the next patchhttps://gitlab.orekit.org/orekit/rugged/-/issues/395update to orekit 12.02023-11-09T07:45:56ZJonathan Guinetupdate to orekit 12.0https://gitlab.orekit.org/orekit/orekit/-/issues/1264Add conversion from (Field)TrackingCoordinates to topocentric position2024-01-18T04:00:30ZRomain SerraAdd conversion from (Field)TrackingCoordinates to topocentric positionThe methods could tentatively be static within TopocentricFrame
[Link](https://forum.orekit.org/t/topocentric-position-from-azelra-coordinates/3055) to the original forum post.The methods could tentatively be static within TopocentricFrame
[Link](https://forum.orekit.org/t/topocentric-position-from-azelra-coordinates/3055) to the original forum post.12.1Tanner MillsTanner Millshttps://gitlab.orekit.org/orekit/orekit/-/issues/1263Remove support for Ant2023-11-08T10:18:37ZBryan CazabonneRemove support for AntMore details in: https://forum.orekit.org/t/removing-support-for-ant/3008/3
Removing support consists in:
- Removing build.xml file
- Removing update of build.xml in release guide task 5
- Removing all occurrences to Ant support in the ...More details in: https://forum.orekit.org/t/removing-support-for-ant/3008/3
Removing support consists in:
- Removing build.xml file
- Removing update of build.xml in release guide task 5
- Removing all occurrences to Ant support in the documentation12.1https://gitlab.orekit.org/orekit/orekit/-/issues/1262Comments in parsed CCSDS file cannot be updated2024-01-16T12:52:09ZDavid GondelachComments in parsed CCSDS file cannot be updatedHi all,
I tried to parse a message that contains comments, e.g. CDM or OEM, and then change or remove some comments before writing it to a file again. However, I was not able to do this. It looks like the comments are stored in a Commen...Hi all,
I tried to parse a message that contains comments, e.g. CDM or OEM, and then change or remove some comments before writing it to a file again. However, I was not able to do this. It looks like the comments are stored in a CommentsContainer and only accessible as a read-only list (Collections.unmodifiableList), hence not modifiable.
The easiest fixes would be to have `CommentsContainer.getComments` return a modifiable List or to add a setter for the List `comments`. I can implement such a change if there are no objections, but maybe you have better ideas!
https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/main/java/org/orekit/files/ccsds/section/CommentsContainer.java
Best,
DavidDavid GondelachDavid Gondelach