From 8d4db1244afa99c50f9a196cf183fbda7c2714bf Mon Sep 17 00:00:00 2001
From: Evan Ward <evan.ward@nrl.navy.mil>
Date: Tue, 22 Jan 2019 14:50:42 -0500
Subject: [PATCH] Fix occasional test failure in NetworkCrawlerTest
Previously if DataProvidersManagerTest ran before NetworkCrawlerTest it would
set data filters (which are static) that would interfere with
NetworkCrawlerTest. Now both tests clear filters.
---
.../java/org/orekit/data/DataProvidersManagerTest.java | 7 +++++++
src/test/java/org/orekit/data/NetworkCrawlerTest.java | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/src/test/java/org/orekit/data/DataProvidersManagerTest.java b/src/test/java/org/orekit/data/DataProvidersManagerTest.java
index 3e7857a52..6d0e141e8 100644
--- a/src/test/java/org/orekit/data/DataProvidersManagerTest.java
+++ b/src/test/java/org/orekit/data/DataProvidersManagerTest.java
@@ -27,6 +27,7 @@ import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.hipparchus.exception.DummyLocalizable;
+import org.junit.After;
import org.junit.Assert;
import org.junit.Test;
import org.orekit.Utils;
@@ -34,6 +35,12 @@ import org.orekit.errors.OrekitException;
public class DataProvidersManagerTest {
+ @After
+ public void tearDown() {
+ // clear the filters so they don't change other tests
+ DataProvidersManager.getInstance().clearFilters();
+ }
+
@Test
public void testDefaultConfiguration() {
System.setProperty(DataProvidersManager.OREKIT_DATA_PATH, getPath("regular-data"));
diff --git a/src/test/java/org/orekit/data/NetworkCrawlerTest.java b/src/test/java/org/orekit/data/NetworkCrawlerTest.java
index be084dbdb..3e15351cc 100644
--- a/src/test/java/org/orekit/data/NetworkCrawlerTest.java
+++ b/src/test/java/org/orekit/data/NetworkCrawlerTest.java
@@ -27,10 +27,17 @@ import java.util.regex.Pattern;
import org.junit.Assert;
import org.junit.Test;
+import org.junit.Before;
import org.orekit.errors.OrekitException;
public class NetworkCrawlerTest {
+ @Before
+ public void setUp() {
+ // Clear any filters that another test may have left
+ DataProvidersManager.getInstance().clearFilters();
+ }
+
@Test(expected=OrekitException.class)
public void noElement() throws MalformedURLException {
File existing = new File(url("regular-data").getPath());
--
GitLab