Raise too stringent convergence threshold in Eckstein-Hechler model.

Fixes #936

Raise too stringent convergence threshold in Eckstein-Hechler model.
Fixes #936
06024fd1 · Luc Maisonobe · 75a6e52f · 06024fd1 · 06024fd1 · 06024fd1
Commit 06024fd1 authored Jun 03, 2022 by Luc Maisonobe
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -21,6 +21,9 @@
  </properties>
  <body>
    <release version="11.2" date="TBD" description="TBD">
+      <action dev="luc" type="fix" issue="936">
+        Raised a too stringent convergence threshold in Eackstein-Hechler model.
+      </action>
      <action dev="bryan" type="add" issue="932">
        Added a way to compute mean parameters in Brouwer-Lyddane model.
      </action>

--- a/src/main/java/org/orekit/propagation/analytical/EcksteinHechlerPropagator.java
+++ b/src/main/java/org/orekit/propagation/analytical/EcksteinHechlerPropagator.java
@@ -565,7 +565,7 @@ public class EcksteinHechlerPropagator extends AbstractAnalyticalPropagator {
        final double epsilon         = 1.0e-13;
        final double thresholdA      = epsilon * (1 + FastMath.abs(current.mean.getA()));
        final double thresholdE      = epsilon * (1 + current.mean.getE());
-        final double thresholdAngles = epsilon * FastMath.PI;
+        final double thresholdAngles = epsilon * MathUtils.TWO_PI;

        int i = 0;
        while (i++ < 100) {

--- a/src/main/java/org/orekit/propagation/analytical/FieldEcksteinHechlerPropagator.java
+++ b/src/main/java/org/orekit/propagation/analytical/FieldEcksteinHechlerPropagator.java
@@ -549,7 +549,7 @@ public class FieldEcksteinHechlerPropagator<T extends CalculusFieldElement<T>> e
        final T epsilon         = one.multiply(1.0e-13);
        final T thresholdA      = epsilon.multiply(current.mean.getA().abs().add(1.0));
        final T thresholdE      = epsilon.multiply(current.mean.getE().add(1.0));
-        final T thresholdAngles = epsilon.multiply(one.getPi());
+        final T thresholdAngles = epsilon.multiply(one.getPi().multiply(2));


        int i = 0;