Skip to content

GitLab

Commit b7deadcc authored by Luc Maisonobe's avatar Luc Maisonobe
Browse files

Added addValidBetween to TimeSpanMap. 

Fixes #833
parent a92750d2
Hide whitespace changes
Inline Side-by-side
src/changes/changes.xml
View file @ b7deadcc
......@@ -29,7 +29,7 @@
</action>
<action dev="luc" type="fix" issue="833">
Added a way to erase all earlier/later transitions when adding an entry
to a TimeSpanMap.
and added addValidBetween to TimeSpanMap.
</action>
<action dev="bryan" type="add">
Added a new and simpler API for State Transition Matrix and Jacobian
......
src/main/java/org/orekit/utils/TimeSpanMap.java
View file @ b7deadcc
......@@ -176,10 +176,7 @@ public class TimeSpanMap<T> {
}
// we need to add a new transition somewhere inside the current span
final Transition<T> transition = new Transition<>(latestValidityDate);
transition.setBefore(span);
transition.setAfter(current);
++nbSpans;
insertTransition(latestValidityDate, span, current);
}
......@@ -260,10 +257,7 @@ public class TimeSpanMap<T> {
start.setAfter(span);
} else {
// we need to add a new transition somewhere inside the current span
final Transition<T> transition = new Transition<>(earliestValidityDate);
transition.setBefore(current);
transition.setAfter(span);
++nbSpans;
insertTransition(earliestValidityDate, current, span);
}
// we consider the last added transition as the new current one
......@@ -271,6 +265,54 @@ public class TimeSpanMap<T> {
}
/** Add an entry valid between two limit dates.
* <p>
* As an entry is valid, it truncates or overrides the validity of the neighboring
* entries already present in the map.
* </p>
* @param entry entry to add
* @param earliestValidityDate date after which the entry is valid
* @param latestValidityDate date before which the entry is valid
* @since 11.1
*/
public synchronized void addValidBetween(final T entry, final AbsoluteDate earliestValidityDate, final AbsoluteDate latestValidityDate) {
// locate spans at earliest and latest dates
locate(earliestValidityDate);
Span<T> latest = current;
while (latest.getEndTransition() != null && latest.getEnd().isBeforeOrEqualTo(latestValidityDate)) {
latest = latest.next();
--nbSpans;
}
if (latest == current) {
// the interval splits one transition in the middle, we need to duplicate the instance
latest = new Span<>(current.data);
if (current.getEndTransition() != null) {
current.getEndTransition().setBefore(latest);
}
}
final Span<T> span = new Span<>(entry);
// manage earliest transition
final Transition<T> start = current.getStartTransition();
if (start != null && start.getDate().equals(earliestValidityDate)) {
// the transition at start of the current span is at the exact same date
// we update it, without adding a new transition
start.setAfter(span);
} else {
// we need to add a new transition somewhere inside the current span
insertTransition(earliestValidityDate, current, span);
}
// manage latest transition
insertTransition(latestValidityDate, span, latest);
// we consider the last added transition as the new current one
current = span;
}
/** Get the entry valid at a specified date.
* <p>
* The expected complexity is O(1) for successive calls with
......@@ -331,6 +373,19 @@ public class TimeSpanMap<T> {
}
/** Insert a transition.
* @param date transition date
* @param before span before transition
* @param after span after transition
* @since 11.1
*/
private void insertTransition(final AbsoluteDate date, final Span<T> before, final Span<T> after) {
final Transition<T> transition = new Transition<>(date);
transition.setBefore(before);
transition.setAfter(after);
++nbSpans;
}
/** Get the first (earliest) transition.
* @return first (earliest) transition, or null if there are no transitions
* @since 11.1
......
src/test/java/org/orekit/utils/TimeSpanMapTest.java
View file @ b7deadcc
......@@ -24,6 +24,7 @@ import org.junit.Before;
import org.junit.Test;
import org.orekit.Utils;
import org.orekit.time.AbsoluteDate;
import org.orekit.utils.TimeSpanMap.Span;
import org.orekit.utils.TimeSpanMap.Transition;
public class TimeSpanMapTest {
......@@ -32,6 +33,7 @@ public class TimeSpanMapTest {
public void testSingleEntry() {
String single = "single";
TimeSpanMap<String> map = new TimeSpanMap<>(single);
checkCountConsistency(map);
Assert.assertSame(single, map.get(AbsoluteDate.CCSDS_EPOCH));
Assert.assertSame(single, map.get(AbsoluteDate.FIFTIES_EPOCH));
Assert.assertSame(single, map.get(AbsoluteDate.FUTURE_INFINITY));
......@@ -49,8 +51,10 @@ public class TimeSpanMapTest {
public void testForwardAdd() {
final AbsoluteDate ref = AbsoluteDate.J2000_EPOCH;
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
checkCountConsistency(map);
for (int i = 1; i < 100; ++i) {
map.addValidAfter(Integer.valueOf(i), ref.shiftedBy(i), false);
checkCountConsistency(map);
}
Assert.assertEquals(0, map.get(ref.shiftedBy(-1000.0)).intValue());
Assert.assertEquals(0, map.get(ref.shiftedBy( -100.0)).intValue());
......@@ -75,14 +79,17 @@ public class TimeSpanMapTest {
}
Assert.assertEquals(99, map.get(ref.shiftedBy( 100.0)).intValue());
Assert.assertEquals(99, map.get(ref.shiftedBy( 1000.0)).intValue());
checkCountConsistency(map);
}
@Test
public void testBackwardAdd() {
final AbsoluteDate ref = AbsoluteDate.J2000_EPOCH;
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
checkCountConsistency(map);
for (int i = -1; i > -100; --i) {
map.addValidBefore(Integer.valueOf(i), ref.shiftedBy(i), false);
checkCountConsistency(map);
}
Assert.assertEquals(0, map.get(ref.shiftedBy( 1000.0)).intValue());
Assert.assertEquals(0, map.get(ref.shiftedBy( 100.0)).intValue());
......@@ -92,6 +99,7 @@ public class TimeSpanMapTest {
}
Assert.assertEquals(-99, map.get(ref.shiftedBy( -100.0)).intValue());
Assert.assertEquals(-99, map.get(ref.shiftedBy(-1000.0)).intValue());
checkCountConsistency(map);
}
@Deprecated
......@@ -164,6 +172,7 @@ public class TimeSpanMapTest {
map.forEach(i -> builder.append(' ').append(i));
Assert.assertEquals(" 0 2 3 5 9 10", builder.toString());
Assert.assertEquals(6, map.getSpansNumber());
checkCountConsistency(map);
}
@Test
......@@ -195,6 +204,125 @@ public class TimeSpanMapTest {
map.forEach(i -> builder.append(' ').append(i));
Assert.assertEquals(" 5 7", builder.toString());
Assert.assertEquals(4, map.getSpansNumber());
checkCountConsistency(map);
}
@Test
public void testAddBetweenEmpty() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
map.addValidBetween(1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-2), AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+2));
Assert.assertEquals(3, map.getSpansNumber());
Assert.assertEquals(0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-3)).intValue());
Assert.assertEquals(1, map.get(AbsoluteDate.ARBITRARY_EPOCH).intValue());
Assert.assertEquals(0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+3)).intValue());
checkCountConsistency(map);
}
@Test
public void testAddBetweenBefore() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
map.addValidBefore(1, AbsoluteDate.ARBITRARY_EPOCH, false);
map.addValidBetween(7, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-4), AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-2));
Assert.assertEquals(4, map.getSpansNumber());
Assert.assertEquals(1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-5)).intValue());
Assert.assertEquals(7, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-3)).intValue());
Assert.assertEquals(1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+3)).intValue());
checkCountConsistency(map);
}
@Test
public void testAddBetweenAfter() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
map.addValidBefore(1, AbsoluteDate.ARBITRARY_EPOCH, false);
map.addValidBetween(7, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2), AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4));
Assert.assertEquals(4, map.getSpansNumber());
Assert.assertEquals(1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-3)).intValue());
Assert.assertEquals(0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy( 1)).intValue());
Assert.assertEquals(7, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy( 3)).intValue());
Assert.assertEquals(0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy( 5)).intValue());
checkCountConsistency(map);
}
@Test
public void testAddBetweenCoveringAll() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
map.addValidAfter(1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1), false);
map.addValidAfter(2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2), false);
map.addValidAfter(3, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(3), false);
map.addValidAfter(4, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4), false);
map.addValidAfter(5, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(5), false);
Assert.assertEquals(6, map.getSpansNumber());
map.addValidBetween(-1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1), AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(6));
Assert.assertEquals( 3, map.getSpansNumber());
Assert.assertEquals( 0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-5)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy( 2)).intValue());
Assert.assertEquals( 5, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+7)).intValue());
checkCountConsistency(map);
}
@Test
public void testAddBetweenCoveringSome() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
map.addValidAfter(1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1), false);
map.addValidAfter(2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2), false);
map.addValidAfter(3, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(3), false);
map.addValidAfter(4, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4), false);
map.addValidAfter(5, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(5), false);
Assert.assertEquals(6, map.getSpansNumber());
map.addValidBetween(-1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1.5), AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4.5));
Assert.assertEquals(5, map.getSpansNumber());
Assert.assertEquals( 0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(0.75)).intValue());
Assert.assertEquals( 1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1.25)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1.75)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4.25)).intValue());
Assert.assertEquals( 4, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4.75)).intValue());
Assert.assertEquals( 5, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(5.25)).intValue());
checkCountConsistency(map);
}
@Test
public void testAddBetweenSplittingOneSpanOnly() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
map.addValidAfter(1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1), false);
map.addValidAfter(2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2), false);
map.addValidAfter(3, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(3), false);
map.addValidAfter(4, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4), false);
map.addValidAfter(5, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(5), false);
Assert.assertEquals(6, map.getSpansNumber());
map.addValidBetween(-1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2.25), AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2.75));
Assert.assertEquals(8, map.getSpansNumber());
Assert.assertEquals( 0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(0.75)).intValue());
Assert.assertEquals( 1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1.99)).intValue());
Assert.assertEquals( 2, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2.01)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2.50)).intValue());
Assert.assertEquals( 2, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2.99)).intValue());
Assert.assertEquals( 3, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(3.01)).intValue());
Assert.assertEquals( 4, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4.25)).intValue());
Assert.assertEquals( 5, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(5.25)).intValue());
checkCountConsistency(map);
}
@Test
public void testAddBetweenExistingDates() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(Integer.valueOf(0));
map.addValidAfter(1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1), false);
map.addValidAfter(2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2), false);
map.addValidAfter(3, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(3), false);
map.addValidAfter(4, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4), false);
map.addValidAfter(5, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(5), false);
Assert.assertEquals(6, map.getSpansNumber());
map.addValidBetween(-1, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2), AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4));
Assert.assertEquals(5, map.getSpansNumber());
Assert.assertEquals( 0, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(0.99)).intValue());
Assert.assertEquals( 1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1.01)).intValue());
Assert.assertEquals( 1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(1.99)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(2.01)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(3.99)).intValue());
Assert.assertEquals( 4, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4.01)).intValue());
Assert.assertEquals( 4, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(4.99)).intValue());
Assert.assertEquals( 5, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(5.01)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -208,6 +336,7 @@ public class TimeSpanMapTest {
map.addValidBefore(Integer.valueOf( 5), ref.shiftedBy( 9.0), false);
TimeSpanMap<Integer> range = map.extractRange(AbsoluteDate.PAST_INFINITY, AbsoluteDate.FUTURE_INFINITY);
Assert.assertEquals(map.getSpansNumber(), range.getSpansNumber());
checkCountConsistency(map);
}
@Test
......@@ -223,6 +352,7 @@ public class TimeSpanMapTest {
Assert.assertEquals(1, range.getSpansNumber());
Assert.assertEquals(5, range.get(ref.shiftedBy(-10000)).intValue());
Assert.assertEquals(5, range.get(ref.shiftedBy(+10000)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -246,6 +376,7 @@ public class TimeSpanMapTest {
Assert.assertEquals( 5, range.get(ref.shiftedBy( 8.9)).intValue());
Assert.assertEquals( 5, range.get(ref.shiftedBy( 9.1)).intValue());
Assert.assertEquals( 5, range.get(ref.shiftedBy( 99.0)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -267,6 +398,7 @@ public class TimeSpanMapTest {
Assert.assertEquals( 9, range.get(ref.shiftedBy( 9.9)).intValue());
Assert.assertEquals(10, range.get(ref.shiftedBy( 10.1)).intValue());
Assert.assertEquals(10, range.get(ref.shiftedBy(100.0)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -286,6 +418,7 @@ public class TimeSpanMapTest {
Assert.assertEquals( 5, range.get(ref.shiftedBy( 8.9)).intValue());
Assert.assertEquals( 5, range.get(ref.shiftedBy( 9.1)).intValue());
Assert.assertEquals( 5, range.get(ref.shiftedBy(999.9)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -334,6 +467,8 @@ public class TimeSpanMapTest {
Assert.assertSame(AbsoluteDate.FUTURE_INFINITY, last.getEnd());
Assert.assertNull(last.getEndTransition());
checkCountConsistency(map);
}
@Test
......@@ -361,6 +496,8 @@ public class TimeSpanMapTest {
Assert.assertEquals( 9, last.getBefore().intValue());
Assert.assertEquals(10, last.getAfter().intValue());
checkCountConsistency(map);
}
@Test
......@@ -373,6 +510,7 @@ public class TimeSpanMapTest {
Assert.assertNull(map.getFirstSpan().getEndTransition());
Assert.assertNull(map.getFirstSpan().previous());
Assert.assertNull(map.getLastSpan().next());
checkCountConsistency(map);
}
@Test
......@@ -412,6 +550,8 @@ public class TimeSpanMapTest {
Assert.assertEquals(0, span.getData().intValue());
Assert.assertNull(span.previous());
checkCountConsistency(map);
}
@Test
......@@ -448,6 +588,8 @@ public class TimeSpanMapTest {
Assert.assertEquals(10.0, transition.getDate().durationFrom(ref), 1.0e-15);
Assert.assertNull(transition.next());
checkCountConsistency(map);
}
@Test
......@@ -458,6 +600,7 @@ public class TimeSpanMapTest {
Assert.assertEquals(2, map.getSpansNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -470,6 +613,7 @@ public class TimeSpanMapTest {
Assert.assertEquals(4, map.getSpansNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -482,6 +626,7 @@ public class TimeSpanMapTest {
Assert.assertEquals(-2, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-10)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertNull(map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)));
checkCountConsistency(map);
}
@Test
......@@ -492,6 +637,7 @@ public class TimeSpanMapTest {
Assert.assertEquals(2, map.getSpansNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -504,6 +650,7 @@ public class TimeSpanMapTest {
Assert.assertEquals(4, map.getSpansNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
checkCountConsistency(map);
}
@Test
......@@ -516,6 +663,16 @@ public class TimeSpanMapTest {
Assert.assertNull(map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)));
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
Assert.assertEquals(+2, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+10)).intValue());
checkCountConsistency(map);
}
private <T> void checkCountConsistency(final TimeSpanMap<T> map) {
final int count1 = map.getSpansNumber();
int count2 = 0;
for (Span<T> span = map.getFirstSpan(); span != null; span = span.next()) {
++count2;
}
Assert.assertEquals(count1, count2);
}
@Before
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment