Skip to content
GitLab
Commit ff37cfc2 authored by Luc Maisonobe's avatar Luc Maisonobe
Browse files

Merge branch 'issue-885' into remove-getTransitions

parents 03e5b1b6 ffd30a4f
Hide whitespace changes
Inline Side-by-side
src/changes/changes.xml
View file @ ff37cfc2
......@@ -21,6 +21,9 @@
</properties>
<body>
<release version="11.1" date="TBD" description="TBD">
<action dev="luc" type="fix" issue="885">
Allow to enter the same transition date in TimeSpanMap several times
</action>
<action dev="luc" type="fix" issue="833">
Added a way to erase all earlier/later transitions when adding an entry
to a TimeSpanMap.
......
src/main/java/org/orekit/utils/TimeSpanMap.java
View file @ ff37cfc2
......@@ -48,15 +48,16 @@ import org.orekit.time.TimeStamped;
* <p>
* Time span maps are built progressively. At first, they contain one
* {@link Span time span} only whose validity extends from past infinity to
* future infinity. Then new entries are added, associated with transition dates,
* in order to build up the complete map. The transition dates can be either the start
* of validity (when calling {@link #addValidAfter(Object, AbsoluteDate, boolean)}),
* or the end of the validity (when calling {#link {@link #addValidBefore(Object,
* AbsoluteDate, boolean)}). Entries are often added at one end only (and mainly
* in chronological order), but this is not required. It is possible for example
* to first set up a map that cover a large range (say one day), and then to insert
* intermediate dates using for example propagation and event detectors to carve out
* some parts. This is akin to the way Binary Space Partitioning Trees work.
* future infinity. Then new entries are added one at a time, associated with
* transition dates, in order to build up the complete map. The transition dates
* can be either the start of validity (when calling {@link #addValidAfter(Object,
* AbsoluteDate, boolean)}), or the end of the validity (when calling {@link
* #addValidBefore(Object, AbsoluteDate, boolean)}). Entries are often added at one
* end only (and mainly in chronological order), but this is not required. It is
* possible for example to first set up a map that cover a large range (say one day),
* and then to insert intermediate dates using for example propagation and event
* detectors to carve out some parts. This is akin to the way Binary Space Partitioning
* Trees work.
* </p>
* @param <T> Type of the data.
* @author Luc Maisonobe
......@@ -102,7 +103,8 @@ public class TimeSpanMap<T> {
* @since 11.1
*/
boolean hasSingleDummyTransition() {
return data.size() == 1 && data.first().getSpanBefore() == data.first().getSpanAfter();
return data.size() == 1 &&
data.first().getSpanBefore().getData() == data.first().getSpanAfter().getData();
}
/** Add an entry valid before a limit date.
......@@ -112,7 +114,6 @@ public class TimeSpanMap<T> {
* </p>
* @param entry entry to add
* @param latestValidityDate date before which the entry is valid
* (must be different from <em>all</em> dates already used for transitions)
* @deprecated as of 11.1, replaced by {@link #addValidBefore(Object, AbsoluteDate, boolean)}
*/
@Deprecated
......@@ -126,12 +127,6 @@ public class TimeSpanMap<T> {
* entries already present in the map.
* </p>
* <p>
* The transition dates should be entered only once, either
* by a call to this method or by a call to {@link #addValidAfter(Object,
* AbsoluteDate, boolean)}. Repeating a transition date will lead to unexpected
* result and is not supported.
* </p>
* <p>
* If the map already contains transitions that occur earlier than {@code latestValidityDate},
* the {@code erasesEarlier} parameter controls what to do with them. Lets consider
* the time span [tₖ ; tₖ₊₁[ associated with entry eₖ that would have been valid at time
......@@ -150,7 +145,6 @@ public class TimeSpanMap<T> {
* </p>
* @param entry entry to add
* @param latestValidityDate date before which the entry is valid
* (must be different from <em>all</em> dates already used for transitions)
* @param erasesEarlier if true, the entry erases all existing transitions
* that are earlier than {@code latestValidityDate}
* @since 11.1
......@@ -175,6 +169,16 @@ public class TimeSpanMap<T> {
if (previous == null) {
// the new transition will be the first one
current.setAfter(data.first().getSpanBefore());
data.add(current);
} else if (previous.getDate().equals(latestValidityDate)) {
// we already have a transition at the exact same date
// we update it, without adding a new transition
final Transition<T> effectivePrevious = previous.getSpanBefore().getStartTransition();
if (effectivePrevious != null) {
effectivePrevious.setAfter(span);
}
previous.setBefore(span); // remember here previous is not really previous, it's current
return;
} else {
current.setAfter(previous.getSpanAfter());
if (erasesEarlier) {
......@@ -186,8 +190,8 @@ public class TimeSpanMap<T> {
// the new transition will be after the previous one
previous.setAfter(span);
}
data.add(current);
}
data.add(current);
}
......@@ -198,7 +202,6 @@ public class TimeSpanMap<T> {
* </p>
* @param entry entry to add
* @param earliestValidityDate date after which the entry is valid
* (must be different from <em>all</em> dates already used for transitions)
* @deprecated as of 11.1, replaced by {@link #addValidAfter(Object, AbsoluteDate, boolean)}
*/
@Deprecated
......@@ -212,12 +215,6 @@ public class TimeSpanMap<T> {
* entries already present in the map.
* </p>
* <p>
* The transition dates should be entered only once, either
* by a call to this method or by a call to {@link #addValidBefore(Object,
* AbsoluteDate, boolean)}. Repeating a transition date will lead to unexpected
* result and is not supported.
* </p>
* <p>
* If the map already contains transitions that occur earlier than {@code earliestValidityDate},
* the {@code erasesEarlier} parameter controls what to do with them. Lets consider
* the time span [tₖ ; tₖ₊₁[ associated with entry eₖ that would have been valid at time
......@@ -236,7 +233,6 @@ public class TimeSpanMap<T> {
* </p>
* @param entry entry to add
* @param earliestValidityDate date after which the entry is valid
* (must be different from <em>all</em> dates already used for transitions)
* @param erasesLater if true, the entry erases all existing transitions
* that are later than {@code earliestValidityDate}
* @since 11.1
......@@ -261,6 +257,16 @@ public class TimeSpanMap<T> {
if (next == null) {
// the new transition will be the last one
current.setBefore(data.last().getSpanAfter());
data.add(current);
} else if (next.getDate().equals(earliestValidityDate)) {
// we already have a transition at the exact same date
// we update it, without adding a new transition
final Transition<T> effectiveNext = next.getSpanAfter().getEndTransition();
if (effectiveNext != null) {
effectiveNext.setBefore(span);
}
next.setAfter(span); // remember here next is not really next, it's current
return;
} else {
current.setBefore(next.getSpanBefore());
if (erasesLater) {
......@@ -272,8 +278,8 @@ public class TimeSpanMap<T> {
// the new transition will be before the next one
next.setBefore(span);
}
data.add(current);
}
data.add(current);
}
......
src/test/java/org/orekit/utils/TimeSpanMapTest.java
View file @ ff37cfc2
......@@ -436,6 +436,74 @@ public class TimeSpanMapTest {
}
@Test
public void testDuplicatedBeforeAfterAtEnd() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(null);
map.addValidBefore(-1, AbsoluteDate.ARBITRARY_EPOCH, false);
map.addValidAfter(+1, AbsoluteDate.ARBITRARY_EPOCH, false);
Assert.assertEquals(1, map.getTransitionsNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
}
@Test
public void testDuplicatedBeforeAfterMiddle() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(null);
map.addValidBefore(-2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-2), false);
map.addValidAfter(+2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+2), false);
map.addValidBefore(-1, AbsoluteDate.ARBITRARY_EPOCH, false);
map.addValidAfter(+1, AbsoluteDate.ARBITRARY_EPOCH, false);
Assert.assertEquals(3, map.getTransitionsNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
}
@Test
public void testDuplicatedBeforeBefore() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(null);
map.addValidBefore(-2, AbsoluteDate.ARBITRARY_EPOCH, false); // first call at ARBITRARY_EPOCH
map.addValidAfter(0, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-2), false);
map.addValidBefore(-1, AbsoluteDate.ARBITRARY_EPOCH, false); // second call at ARBITRARY_EPOCH
Assert.assertEquals(2, map.getTransitionsNumber());
Assert.assertEquals(-2, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-10)).intValue());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertNull(map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)));
}
@Test
public void testDuplicatedAfterBeforeAtEnd() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(null);
map.addValidAfter(+1, AbsoluteDate.ARBITRARY_EPOCH, false);
map.addValidBefore(-1, AbsoluteDate.ARBITRARY_EPOCH, false);
Assert.assertEquals(1, map.getTransitionsNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
}
@Test
public void testDuplicatedAfterBeforeMiddle() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(null);
map.addValidBefore(-2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-2), false);
map.addValidAfter(+2, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+2), false);
map.addValidAfter(+1, AbsoluteDate.ARBITRARY_EPOCH, false);
map.addValidBefore(-1, AbsoluteDate.ARBITRARY_EPOCH, false);
Assert.assertEquals(3, map.getTransitionsNumber());
Assert.assertEquals(-1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)).intValue());
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
}
@Test
public void testDuplicatedAfterAfter() {
TimeSpanMap<Integer> map = new TimeSpanMap<>(null);
map.addValidAfter(+2, AbsoluteDate.ARBITRARY_EPOCH, false); // first call at ARBITRARY_EPOCH
map.addValidBefore(0, AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+2), false);
map.addValidAfter(+1, AbsoluteDate.ARBITRARY_EPOCH, false); // second call at ARBITRARY_EPOCH
Assert.assertEquals(2, map.getTransitionsNumber());
Assert.assertNull(map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(-1)));
Assert.assertEquals(+1, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+1)).intValue());
Assert.assertEquals(+2, map.get(AbsoluteDate.ARBITRARY_EPOCH.shiftedBy(+10)).intValue());
}
@Before
public void setUp() {
Utils.setDataRoot("regular-data");
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment