Orekit issueshttps://gitlab.orekit.org/orekit/orekit/-/issues2023-12-30T11:43:37Zhttps://gitlab.orekit.org/orekit/orekit/-/issues/1261Javadoc still refers to old name of yields2023-12-30T11:43:37ZRomain SerraJavadoc still refers to old name of yieldsFor (Field) AdditionalStateProvider as well as AdditionalDerivativesProvider, some Javadoc still references the old name of method `yields` that used to be called `yield`For (Field) AdditionalStateProvider as well as AdditionalDerivativesProvider, some Javadoc still references the old name of method `yields` that used to be called `yield`12.0.1Tanner MillsTanner Millshttps://gitlab.orekit.org/orekit/orekit/-/issues/1271Add Intellij checkstyle configuration in contributing.md2023-12-30T11:41:58ZBryan CazabonneAdd Intellij checkstyle configuration in contributing.mdIt would be great to add Checkstyle configuration for Intellij in the contributing.md file.It would be great to add Checkstyle configuration for Intellij in the contributing.md file.12.0.1Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/1280Add missing contributions for 12.0 in changes.xml2023-12-30T11:40:01ZMaxime JournotAdd missing contributions for 12.0 in changes.xmlSome contributions for fixing issues #1203 and #982 are missing in the changes.xml for v 12.0Some contributions for fixing issues #1203 and #982 are missing in the changes.xml for v 12.012.0.1Maxime JournotMaxime Journothttps://gitlab.orekit.org/orekit/orekit/-/issues/1037Several javadocs need to be updated due to the change in EventDetector/EventH...2023-11-08T20:28:09ZPascal ParraudSeveral javadocs need to be updated due to the change in EventDetector/EventHandler.Following the refactoring of EventDetector/EventHandler (!336), the documentation of several classes and methods should be updated to reflect the changes (e.g. the javadoc of the `eventOccured` method of the `EventHandler` interface alwa...Following the refactoring of EventDetector/EventHandler (!336), the documentation of several classes and methods should be updated to reflect the changes (e.g. the javadoc of the `eventOccured` method of the `EventHandler` interface always references the `eventOccured` method of the `EventDetector` class which no longer exists, the javadoc of the `init` method of the `EventDetector` interface mentions the handler instead of the detector, ...).
As the changes are significant, it would be nice if the documentation was more precise.12.0https://gitlab.orekit.org/orekit/orekit/-/issues/1251Add missing new contributors2023-11-02T20:41:35ZMaxime JournotAdd missing new contributorsSome contributors of 12.0 were not added to the pom.xml file and their contributions not added to changes.xml.
Here is a (potentially not exhaustive) list:
- [Rongwang Li](https://gitlab.orekit.org/orekit/orekit/-/merge_requests/306)
- ...Some contributors of 12.0 were not added to the pom.xml file and their contributions not added to changes.xml.
Here is a (potentially not exhaustive) list:
- [Rongwang Li](https://gitlab.orekit.org/orekit/orekit/-/merge_requests/306)
- [Theo Nguyen](https://gitlab.orekit.org/orekit/orekit/-/merge_requests/414)
- [Julien Asquier](https://gitlab.orekit.org/orekit/orekit/-/merge_requests/357)12.0Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/1192Revamp (Field)SpacecraftState2023-10-26T15:47:45ZRomain SerraRevamp (Field)SpacecraftStateBoth classes have a few minor problems, including:
- Javadoc is not up to date, especially regarding the `AbsolutePVCoordinates` option
- The default, undisclosed attitude is hard coded several times and could actually be switched to a `...Both classes have a few minor problems, including:
- Javadoc is not up to date, especially regarding the `AbsolutePVCoordinates` option
- The default, undisclosed attitude is hard coded several times and could actually be switched to a `FrameAlignedProvider` for performance (instead of an `LofOffset`)12.0Romain SerraRomain Serrahttps://gitlab.orekit.org/orekit/orekit/-/issues/1066Fix MarshallSolarActivityFutureEstimation javadoc2023-10-26T09:30:22ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euFix MarshallSolarActivityFutureEstimation javadocHi everyone,
I noticed that the "Marshall Solar Activity website" link provided in the ```MarshallSolarActivityFutureEstimation``` class javadoc is dead and need to be updated.
The new link seems to be this one : https://www.nasa.gov/...Hi everyone,
I noticed that the "Marshall Solar Activity website" link provided in the ```MarshallSolarActivityFutureEstimation``` class javadoc is dead and need to be updated.
The new link seems to be this one : https://www.nasa.gov/msfcsolar
Cheers,
Vincent12.0https://gitlab.orekit.org/orekit/orekit/-/issues/1181Misleading javadoc for angles only IOD2023-10-01T13:13:09ZRomain SerraMisleading javadoc for angles only IOD`AbstractAnglesOnlyIod` header says that the orbit is determined "from three position vector". It should rather be "from three lines of sight w.r.t. their respective observers inertial positions vectors".
The acronym IOD should also pro...`AbstractAnglesOnlyIod` header says that the orbit is determined "from three position vector". It should rather be "from three lines of sight w.r.t. their respective observers inertial positions vectors".
The acronym IOD should also probably be defined somewhere.12.0https://gitlab.orekit.org/orekit/orekit/-/issues/1168Marshall Solar Activity website link is down in MarshallSolarActivityFutureEs...2023-09-26T09:58:42ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euMarshall Solar Activity website link is down in MarshallSolarActivityFutureEstimationHi everyone,
I noticed that the link in the ```MarshallSolarActivityFutureEstimation``` class leading to the Marshall Solar Activity website is down.
Cheers,
VincentHi everyone,
I noticed that the link in the ```MarshallSolarActivityFutureEstimation``` class leading to the Marshall Solar Activity website is down.
Cheers,
Vincent12.0Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/issues/1063Fix javadoc for SpacecraftState constructor using an AbsolutePVCoordinates an...2023-09-21T08:09:13ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euFix javadoc for SpacecraftState constructor using an AbsolutePVCoordinates and no attitudeHi everyone,
I noticed that for the constructors in ```SpacecraftState``` that use an ```AbsolutePVCoordinates``` instead of an ```Orbit``` and no ```Attitude```, the javadoc does not mention the fact that the ```AbsolutePVCoordinates``...Hi everyone,
I noticed that for the constructors in ```SpacecraftState``` that use an ```AbsolutePVCoordinates``` instead of an ```Orbit``` and no ```Attitude```, the javadoc does not mention the fact that the ```AbsolutePVCoordinates``` must be defined in a pseudo-inertial frame and will throw an error otherwise.
Indeed, this kind of constructor creates a default ```LofOffset``` attitude law which require a pseudo-inertial frame.
Cheers,
Vincent12.0https://gitlab.orekit.org/orekit/orekit/-/issues/985Internal page overview.html not up to date2023-08-28T15:43:12ZMaxime JournotInternal page overview.html not up to dateThe features list in [overview.html](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/main/java/org/orekit/overview.html) page which is maintained directly in the repository at `src/main/java` is not up to date with the generat...The features list in [overview.html](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/main/java/org/orekit/overview.html) page which is maintained directly in the repository at `src/main/java` is not up to date with the generated site [index.md](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/site/markdown/index.md) or the [Overview page on Orekit website](https://orekit.org/overview.html).
Shall we keep this internal html page ? I'm not sure I understand its use.
If yes, it should be updated and point 5 of the [release guide](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/site/markdown/release-guide.md) ("Updating documentation") should explicitly refer to it, so that the release manager doesn't forget to update it :wink:12.0https://gitlab.orekit.org/orekit/orekit/-/issues/1057DSSTThirdBody Java doc warning about the µ constant to use2023-07-02T13:23:16ZJulienLDSSTThirdBody Java doc warning about the µ constant to useHi,
Recently, I posted the the orekit python wrapper forum about strange results I got with the DSSTPropagator. I created a DSSTThirdBody and wanted to add it as a ForceModel. Fact is that I put the µ of the Third body instead of the µ ...Hi,
Recently, I posted the the orekit python wrapper forum about strange results I got with the DSSTPropagator. I created a DSSTThirdBody and wanted to add it as a ForceModel. Fact is that I put the µ of the Third body instead of the µ of the central body. It is at first glance conter-intuitive and should be warned in the java documentation.
- Link of the forum here : https://forum.orekit.org/t/dsst-propagation-results-seems-odd/2371/9
- Link of the documentation : https://www.orekit.org/site-orekit11.3.2/apidocs/org/orekit/propagation/semianalytical/dsst/forces/DSSTThirdBody.html11.3.3Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/977Remove reference to old Orekit mailing list in `LocalOrbitalFrame`2023-02-16T22:00:00ZMaxime JournotRemove reference to old Orekit mailing list in `LocalOrbitalFrame`There's a reference to the old Orekit mailing list in the fielded version of [LocalOrbitFrame.LocalProvider.getTransform](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/main/java/org/orekit/frames/LocalOrbitalFrame.java#L103)...There's a reference to the old Orekit mailing list in the fielded version of [LocalOrbitFrame.LocalProvider.getTransform](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/main/java/org/orekit/frames/LocalOrbitalFrame.java#L103):
```
throw new UnsupportedOperationException(
"FieldTransforms are not supported for a LocalOrbitalFrame: " + name +
". Please contact orekit-developers@orekit.org if you " +
"would like to add this feature.");
```
This should be removed and replaced with a proper message and a reference to the forum.11.3.2Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/984Missing Onsala Space Observatory BLQ file formats in supported data types2023-02-16T22:00:00ZMaxime JournotMissing Onsala Space Observatory BLQ file formats in supported data types[Support data types](https://www.orekit.org/site-orekit-development/index.html) page in the generated site is missing the Onsala Space Observatory BLQ file formats for Ocean tides loading (see the [OceanLoadingCoefficientsBLQFactory](htt...[Support data types](https://www.orekit.org/site-orekit-development/index.html) page in the generated site is missing the Onsala Space Observatory BLQ file formats for Ocean tides loading (see the [OceanLoadingCoefficientsBLQFactory](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/main/java/org/orekit/models/earth/displacement/OceanLoadingCoefficientsBLQFactory.java) class).11.3.2Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/1018Improve Orekit GLONASS Propagator Documentation2023-02-15T21:12:13ZJonathan HoodImprove Orekit GLONASS Propagator Documentation@bryan
As requested by Bryan, opening an issue to improve the Orekit documentation for GLONASSAnalytical and GLONASSNumerical propagators to indicate that Analytical should be used for almanacs and Numerical for ephemeris data. Include ...@bryan
As requested by Bryan, opening an issue to improve the Orekit documentation for GLONASSAnalytical and GLONASSNumerical propagators to indicate that Analytical should be used for almanacs and Numerical for ephemeris data. Include in each references to the other.11.3.2Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/978Incomplete documentation of covariance coordinates transformation and shifting2022-12-24T10:12:05ZRomain SerraIncomplete documentation of covariance coordinates transformation and shiftingIn the `StateCovariance` class, the `changeCovarianceType` enables to change the coordinates of the state, using the Jacobian matrix of the transformation i.e. a linear approximation. This needs to be made clear in the documentation, as ...In the `StateCovariance` class, the `changeCovarianceType` enables to change the coordinates of the state, using the Jacobian matrix of the transformation i.e. a linear approximation. This needs to be made clear in the documentation, as coordinate changes are usually non-linear mappings, meaning the actual covariance matrix does not exactly match the linearized case (and the distribution is not in general Gaussian anymore).
As for frame changes, they are usually linear so the linearization does not introduce any approximation.
The word "linearization" should also appear in the `shiftBy` method, as again propagation is usually non-linear.11.3.1Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/issues/1012Typo in IsotropicRadiationClassicalConvention documentation2022-12-24T09:59:27ZLuc MaisonobeTypo in IsotropicRadiationClassicalConvention documentationThe javadoc for class `IsotropicRadiationClassicalConvention` mentions both Kd and Cd
for the name fo diffuse reflection coefficient. For consistency with Ca (absorption)
and Cs (specular reflection), only Cd should be kept in the Javadoc.The javadoc for class `IsotropicRadiationClassicalConvention` mentions both Kd and Cd
for the name fo diffuse reflection coefficient. For consistency with Ca (absorption)
and Cs (specular reflection), only Cd should be kept in the Javadoc.Luc MaisonobeLuc Maisonobehttps://gitlab.orekit.org/orekit/orekit/-/issues/983parabolic and hyperbolic Keplerian orbit2022-12-18T14:44:41ZLuc Maisonobeparabolic and hyperbolic Keplerian orbitThe overview page in the generated maven site (src/site/markdown/index.md) and the
equivalent in the javadoc (src/main/java/org/orekit/overview.html) both states that
Orekit support "elliptical Keplerian" orbits when in fact parabolic an...The overview page in the generated maven site (src/site/markdown/index.md) and the
equivalent in the javadoc (src/main/java/org/orekit/overview.html) both states that
Orekit support "elliptical Keplerian" orbits when in fact parabolic and hyperbolic
Keplerian orbit have been supported too for decades now.12.0https://gitlab.orekit.org/orekit/orekit/-/issues/840Wrong name for files.ccsds.ndm.adm.AttitudeEndoints class2022-12-17T19:55:57ZBryan CazabonneWrong name for files.ccsds.ndm.adm.AttitudeEndoints classCurrent class name is `AttitudeEndoints`. However, it must be `AttitudeEndpoints`. The "p" letter is missing.
Because it changes the name of a public class, this change must wait the next major release.Current class name is `AttitudeEndoints`. However, it must be `AttitudeEndpoints`. The "p" letter is missing.
Because it changes the name of a public class, this change must wait the next major release.12.0Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/issues/948Update release guide for patch version2022-10-07T18:50:52ZMaxime JournotUpdate release guide for patch versionSince releasing a patch version is a bit different than releasing a minor or major version, the [release guide](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/site/markdown/release-guide.md) should be updated accordingly.
Ma...Since releasing a patch version is a bit different than releasing a minor or major version, the [release guide](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/site/markdown/release-guide.md) should be updated accordingly.
Main differences are:
- Some steps aren't necessary in a patch release (updating Maven plugins, calling for a vote etc.)
- Some branches are different too (release-xx branch already exists, and the MR are merged directly on it, we don't use the develop branch)
- Some steps are missing (explain how to merge the MR, how to cherry-pick commits if needed)
Also some information in the [contribution guide](https://gitlab.orekit.org/orekit/orekit/-/blob/develop/src/site/markdown/contributing.md) should be updated:
- Developers should start from latest release branch instead of current develop branch for non API-regressive bug corrections
- changes.xml does not need to be updated when fixing this type of bug
All this to simplify the work for the releaser.11.3Maxime JournotMaxime Journot