Orekit merge requestshttps://gitlab.orekit.org/orekit/orekit/-/merge_requests2024-03-25T14:46:29Zhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/501Fixed creating an AbsoluteDate from JD in TDB timescale.2024-03-25T14:46:29ZMaxime JournotFixed creating an AbsoluteDate from JD in TDB timescale.Closes #1310Closes #1310Maxime JournotMaxime Journothttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/500Draft: Fix issue 1357: Zeros in unscented covariance2024-03-29T05:03:37ZMark RuttenDraft: Fix issue 1357: Zeros in unscented covarianceThis fix is for issue #1357 and simply changes `getEvolution` in `UnscentedKalmanModel` to copy across the non-orbit parts of the input sigma points into the predicted sigma points.
I needed to change the initial covariance matrix in `U...This fix is for issue #1357 and simply changes `getEvolution` in `UnscentedKalmanModel` to copy across the non-orbit parts of the input sigma points into the predicted sigma points.
I needed to change the initial covariance matrix in `UnscentedKalmanModelTest` because it wasn't positive definite. I've just changed it to be diagonal.
I haven't added a new test for this bug. Would that be a good idea?Mark RuttenMark Ruttenhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/495Fix DSST Jacobians for force model parameters2024-03-15T15:29:41ZEvan WardFix DSST Jacobians for force model parametersPreviously the DSST would throw an exception if attempting to compute
the jacobian w.r.t. a force model parameter. Now it seems to work.
Changes include:
* initializing field short period terms when computing Jacobians.
* using Equin...Previously the DSST would throw an exception if attempting to compute
the jacobian w.r.t. a force model parameter. Now it seems to work.
Changes include:
* initializing field short period terms when computing Jacobians.
* using EquinoctialOrbit, not CartesianOrbit for DSST.
* only consider the short period terms for parameters in the force
model that created the short period terms.
I added tests that check running the DSST with zero, one, or two
parameters in mean and osculating mode. Had to slightly increase the
tolerance on an existing DSST paramter Jacobian test. But the DSST
LAGEOS OD test completed in fewer iteration, leading me to believe it
was an improvement to the Jacobian.
The changes caused some of the DSST KF tests to no longer work.
Those tests seem to create a MEAN DSST propagator, then replace all of
the short period terms with OSCULATING ones, without updating the field terms. I'm not sure if this even
makes sense from the theory or should be supported, but apparently it
worked before. So I adjusted the KF to also update the field terms when it updates the non-field terms.
I also addes some supporting test and debugging code.
Fixes #98612.0.2Evan WardEvan Wardhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/474Fix issue-1309: Incorrect transmitter location in BistaticRange measurement2024-02-21T17:19:45ZMark RuttenFix issue-1309: Incorrect transmitter location in BistaticRange measurementFix incorrect transmitter location, issue #1309.
Took the opportunity to reduce code by using the common ground measurement calculations.
Should I have a go at reducing the code in `BistaticRangeRate` as well?Fix incorrect transmitter location, issue #1309.
Took the opportunity to reduce code by using the common ground measurement calculations.
Should I have a go at reducing the code in `BistaticRangeRate` as well?12.0.2https://gitlab.orekit.org/orekit/orekit/-/merge_requests/471Draft: Fixed issue 1282 : mismatch between LOFType.EQW Javadoc and code2024-01-23T07:50:03ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euDraft: Fixed issue 1282 : mismatch between LOFType.EQW Javadoc and codeHi all,
this mr fixes issue 1282.
closes #1282
Cheers,
VincentHi all,
this mr fixes issue 1282.
closes #1282
Cheers,
VincentVincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/469Fix #1300 Regression in ephemeris interpolation2024-01-19T12:16:00ZEvan WardFix #1300 Regression in ephemeris interpolationFix interpolation in Ephemeris when interpolationPoints=1. I.e. stepwise
interpolations. Thanks to Sander Cochran for the failing test case.Fix interpolation in Ephemeris when interpolationPoints=1. I.e. stepwise
interpolations. Thanks to Sander Cochran for the failing test case.12.0.2Evan WardEvan Wardhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/465Closes #1296: Make lazy loading of UTC thread safe by checking if already...2024-03-16T14:25:37ZChristopher SchankCloses #1296: Make lazy loading of UTC thread safe by checking if already...Fix issue-1296: Make lazy loading of UTC thread safe by checking if already loaded inside synchronized block
Closes #1296Fix issue-1296: Make lazy loading of UTC thread safe by checking if already loaded inside synchronized block
Closes #129612.0.2https://gitlab.orekit.org/orekit/orekit/-/merge_requests/462Draft: Fixed issue 1273: Resolve "TimeSystem parsing in SP3Parser"2024-03-16T14:26:17ZMark RuttenDraft: Fixed issue 1273: Resolve "TimeSystem parsing in SP3Parser"Closes #1273.
I've fixed the bug and added a single test. I've included a partial QZSS SP3 file, with the number of time-steps edited down to one.Closes #1273.
I've fixed the bug and added a single test. I've included a partial QZSS SP3 file, with the number of time-steps edited down to one.12.0.2https://gitlab.orekit.org/orekit/orekit/-/merge_requests/459#1253: Fixed covariance computation with ephemeris propagation.2023-12-29T13:38:40ZMaxime Journot#1253: Fixed covariance computation with ephemeris propagation.Fixes #1253Fixes #125312.0.1https://gitlab.orekit.org/orekit/orekit/-/merge_requests/457#1254: Avoid bad dates in ephemeris when reset-at-end is set to false.2023-12-29T13:39:47ZMaxime Journot#1254: Avoid bad dates in ephemeris when reset-at-end is set to false.Fixes #1254Fixes #125412.0.1https://gitlab.orekit.org/orekit/orekit/-/merge_requests/453Fixed issue 1277 : Regression in computation speed when using Ephemeris2023-12-29T14:04:39ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euFixed issue 1277 : Regression in computation speed when using EphemerisHey everyone,
Opening this mr to fix the regression in performance when using ```Ephemeris```.
With this fix, i managed to heavily reduce the computation time but it is still not as efficient as in the 11.3.3. For example, in the test ...Hey everyone,
Opening this mr to fix the regression in performance when using ```Ephemeris```.
With this fix, i managed to heavily reduce the computation time but it is still not as efficient as in the 11.3.3. For example, in the test provided [in this thread](https://forum.orekit.org/t/decreased-computation-speed-of-eventdetector-in-orekit-12-0/3097/5), we had the following computation times :
- In 11.3.3 : 800 ms
- In 12.0 (without fix) : 66549 ms
- In 12.0 (with fix) : 2000 ms
We could earn around 500 ms by removing the check that is done on each interpolation to verify that all the states are consistently defined (only orbits OR absolute pv coordinates). Another way to reduce this time would be to deactivate the chronological sort in the ```ImmutableTimeStampedCache``` when we know that the sample is already sorted chronologically.
Also, this computation time does not scale linearly with the number of states in the sample. For example, when i doubled the amount of states in the previous test, it took 2500 ms with the fix so only 500 ms more than with half the sample.
I believe that this is reasonable considering that every interpolation is perfectly threadsafe.
closes #1277.
Cheers,
Vincent12.0.1Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/452Fixed issue 1055 : Fixed bad caching of the ocean tides model.2023-12-29T13:38:10ZBryan CazabonneFixed issue 1055 : Fixed bad caching of the ocean tides model.Fixes #1055Fixes #105512.0.1https://gitlab.orekit.org/orekit/orekit/-/merge_requests/450Fixed issue 1230 : AberrationModifier shall be used with user defined DataCon...2023-12-29T13:43:25ZBryan CazabonneFixed issue 1230 : AberrationModifier shall be used with user defined DataContext.Fixes #1230Fixes #123012.0.1https://gitlab.orekit.org/orekit/orekit/-/merge_requests/448Fixed issue 1269: Infinite loop when using specific date with CssiSpaceWeathe...2023-12-29T14:04:42ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euFixed issue 1269: Infinite loop when using specific date with CssiSpaceWeatherDataHi everyone,
Closes #1269.
Cheers,
VincentHi everyone,
Closes #1269.
Cheers,
Vincent12.0.1Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/447Fixed issue 1266 : SpacecraftStateInterpolator constructor ignores extrapolat...2023-12-29T13:41:23ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euFixed issue 1266 : SpacecraftStateInterpolator constructor ignores extrapolation thresholdHi everyone,
Fixes #1266.
Cheers,
VincentHi everyone,
Fixes #1266.
Cheers,
Vincent12.0.1Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/423Fixed 1208 : Default settings give errors in ssa package2023-10-16T16:26:10ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euFixed 1208 : Default settings give errors in ssa packageHey everyone,
Thanks to the amazing work of dgondelach in [this thread](https://forum.orekit.org/t/collision-probability-algorithms-default-settings-give-errors/2899/3), I was able to quickly fix this issue.
PS: I tried to tweak some t...Hey everyone,
Thanks to the amazing work of dgondelach in [this thread](https://forum.orekit.org/t/collision-probability-algorithms-default-settings-give-errors/2899/3), I was able to quickly fix this issue.
PS: I tried to tweak some tests to fix #1153 as well but cannot be sure until someone test it on a Linux OS.
UPDATE : @Serrof, I find it weird that we find the same results as the ones from the [CARA analysis tool](https://github.com/nasa/CARA_Analysis_Tools/blob/master/two-dimension_Pc/Main/ProbabilityOfCollisionCode/Pc2D_Foster.m) when the tests are about very low relative velocity encounter ? Could you take a look ?
Cheers,
Vincent12.0Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/417Fixed issue 1205: Failing tests after correction of Hipparchus issue 2532023-09-25T19:34:29ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euFixed issue 1205: Failing tests after correction of Hipparchus issue 253Hey everyone,
This mr aims to fix the errors introduced by the fix of hipparchus issue 253.
I fixed the failing tests in the SSA package but some tests still need to be fixed :
```
869472 [ERROR] HaloOrbitTest.testManifolds:158 » Mat...Hey everyone,
This mr aims to fix the errors introduced by the fix of hipparchus issue 253.
I fixed the failing tests in the SSA package but some tests still need to be fixed :
```
869472 [ERROR] HaloOrbitTest.testManifolds:158 » MathIllegalArgument non symmetric matrix: th...
869472 [ERROR] LyapunovOrbitTest.testManifolds:150 » MathIllegalArgument non symmetric matrix...
```
Closes #1205
Cheers,
Vincent12.0Vincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/416Draft: Fixed issue 1205: failing tests after correction of Hipparchus issue 2532023-10-18T21:38:01ZVincent CUCCHIETTIvincent.cucchietti@csgroup.euDraft: Fixed issue 1205: failing tests after correction of Hipparchus issue 253Hey everyone,
This mr aims to fix the errors introduced by the fix of hipparchus issue 253.
I fixed the failing tests in the SSA package but some tests still need to be fixed :
```
869472 [ERROR] HaloOrbitTest.testManifolds:158 » Mat...Hey everyone,
This mr aims to fix the errors introduced by the fix of hipparchus issue 253.
I fixed the failing tests in the SSA package but some tests still need to be fixed :
```
869472 [ERROR] HaloOrbitTest.testManifolds:158 » MathIllegalArgument non symmetric matrix: th...
869472 [ERROR] LyapunovOrbitTest.testManifolds:150 » MathIllegalArgument non symmetric matrix...
```
Closes #1205
Cheers,
VincentVincent CUCCHIETTIvincent.cucchietti@csgroup.euVincent CUCCHIETTIvincent.cucchietti@csgroup.euhttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/415Fix multiple regressions in IOD2023-10-01T13:13:02ZBryan CazabonneFix multiple regressions in IODCloses #1181, #1196 and #1216
I finally decided to remove the abstract class. Each angular based IOD method has its own specifications (Gooding needs range guesses, Laplace needs PV coordinates of one observer, Gauss needs the position...Closes #1181, #1196 and #1216
I finally decided to remove the abstract class. Each angular based IOD method has its own specifications (Gooding needs range guesses, Laplace needs PV coordinates of one observer, Gauss needs the position of 3 observers). Therefore, having an abstract class isn't an easy task here and trying to find "common" signatures can only introduce noise and bad practicies.12.0Bryan CazabonneBryan Cazabonnehttps://gitlab.orekit.org/orekit/orekit/-/merge_requests/413Fix issues 1188 & 1199 : Add setters in ccsds classes & CDM xml file values ...2023-09-22T15:14:48ZLUGANFix issues 1188 & 1199 : Add setters in ccsds classes & CDM xml file values truncated at readingSee https://forum.orekit.org/t/cdm-xml-file-values-truncated-at-reading/2870/2 and https://forum.orekit.org/t/setters-in-cdm-objects/2831/2
Closes #1188
Closes #1199See https://forum.orekit.org/t/cdm-xml-file-values-truncated-at-reading/2870/2 and https://forum.orekit.org/t/setters-in-cdm-objects/2831/2
Closes #1188
Closes #119912.0LUGANLUGAN