Change of AbstractGNSSAttitudeProvider from public to non-public.
Petrus Hyvönen petrus.hyvonen@gmail.com a écrit :
Hi Luc,
Hi Petrus,
I'm mailing you directly, let me know if you prefer to take such discussions through the forum.
I'm working on creating python extension classes more systematic for all the interfaces and Abstract classes (where it is not stated that they are for internal use, or otherwise low sense).
I ran into some issue with the AbstractGNSSAttitudeProvider. The correctedYaw(GNSSAttitudeContext context); uses the GNSSAttitudeContext which is non-public and only visible within the attitude package. (python extension classes go to org.orekit.python) Is the idea that this abstract class is not intended for common use, or should the GNSSAttitudeContext be public maybe?
Good catch!
This abstract class is not intended for public use, only the
GNSSAttitudeProvider
interface should be public.
Could you open an issue on the gitlab forge to ask for changing visibility to
package private? We cannot fix it for 9.3 since it was already
published in 9.2,
so we have to wait until 10.0. I doubt anybody implemented another
implementation,
but prefer to be safe.
best regards, Luc