Commit 04f1b5f0 authored by Luc Maisonobe's avatar Luc Maisonobe

Replaced FindBugs by SpotBugs.

FindBugs is not maintained anymore, SpotBugs is its successor.
parent f55ba1db
......@@ -20,7 +20,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<orekit.findbugs-maven-plugin.version>3.0.4</orekit.findbugs-maven-plugin.version>
<orekit.spotbugs-maven-plugin.version>3.1.7</orekit.spotbugs-maven-plugin.version>
<orekit.jacoco-maven-plugin.version>0.7.9</orekit.jacoco-maven-plugin.version>
<orekit.maven-assembly-plugin.version>3.0.0</orekit.maven-assembly-plugin.version>
<orekit.maven-bundle-plugin.version>3.3.0</orekit.maven-bundle-plugin.version>
......@@ -596,13 +596,13 @@
<version>${orekit.maven-project-info-reports-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
<version>${orekit.findbugs-maven-plugin.version}</version>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${orekit.spotbugs-maven-plugin.version}</version>
<configuration>
<threshold>Normal</threshold>
<effort>Default</effort>
<excludeFilterFile>${basedir}/findbugs-exclude-filter.xml</excludeFilterFile>
<excludeFilterFile>${basedir}/spotbugs-exclude-filter.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
......
<?xml version="1.0"?>
<!--
This file contains some false positive bugs detected by findbugs. Their
This file contains some false positive bugs detected by spotbugs. Their
false positive nature has been analyzed individually and they have been
put here to instruct findbugs it must ignore them.
put here to instruct spotbugs it must ignore them.
-->
<FindBugsFilter>
......@@ -54,7 +54,7 @@
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
</Match>
<!-- the following are in fact false positives from findbugs -->
<!-- the following are in fact false positives from SpotBugs -->
<!-- their occurrence depends on the java compiler used -->
<Match>
<Class name="~.*\.EcksteinHechlerPropagator$"/>
......@@ -128,7 +128,7 @@
<Bug pattern="CNT_ROUGH_CONSTANT_VALUE" />
</Match>
<!-- The following is a false positive from findbugs -->
<!-- The following is a false positive from SpotBugs -->
<Match>
<Class name="~.*\.IntegratedEphemeris\$LocalProvider$"/>
<Method name="getAdditionalState" />
......
......@@ -13,7 +13,7 @@
<include>pom.xml</include>
<include>build.xml</include>
<include>checkstyle.xml</include>
<include>findbugs-exclude-filter.xml</include>
<include>spotbugs-exclude-filter.xml</include>
<include>license-header.txt</include>
</includes>
<useDefaultExcludes>true</useDefaultExcludes>
......
......@@ -81,7 +81,7 @@ with the following command:
For other commands like generating the site, or generating the
[checkstyle](http://checkstyle.sourceforge.net/),
[findbugs](http://findbugs.sourceforge.net/) or
[spotbugs](https://spotbugs.github.io/) or
[jacoco](http://www.eclemma.org/jacoco/) reports, see the maven
plugins documentation at [maven site](http://maven.apache.org/plugins/index.html).
......
......@@ -42,7 +42,7 @@ The second goal, robustness, has some specific implications for a low level
component like Orekit. In some sense, it can be considered an extension of the
previous goal as it can also be improved by testing. It can also be improved
by automatic checking tools that analyze either source code or binary code. The
[findbugs](http://findbugs.sourceforge.net/) tool is already configured for
[spotbugs](https://spotbugs.github.io/) tool is already configured for
automatic checks of the library using a maven plugin.
This is however not sufficient. A library is intended to be used by applications
......@@ -204,9 +204,9 @@ root directory.
seek for a line test coverage of at least 80% (more is better)
* *findbugs* (robustness)
* *spotbugs* (robustness)
fix _all_ errors and warnings found by findbugs
fix _all_ errors and warnings found by spotbugs
* *no runtime assumptions* (robustness)
......
......@@ -65,7 +65,7 @@ are taught:
* Eclipse integrated development environment
* Maven build tool
* Testing tools (Junit, Jacoco)
* Auditing tools (Checkstyle, Findbugs, PMD ...)
* Auditing tools (Checkstyle, SpotBugs, PMD ...)
| type | prerequisites | duration |
|------------------------------|-------------------------------------------------------------------|-----------|
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment