Commit 2ae83175 authored by Luc Maisonobe's avatar Luc Maisonobe

Fixed an error in derivatives.

The scale factor should *not* be applied here, it is applied at
estimation level where we manage normalized parameters. Here
we manage physical parameters directly.
parent 34ccbb56
......@@ -55,7 +55,10 @@ public class Bias<T extends Measurement<T>> implements EvaluationModifier<T> {
derivatives = new double[bias.length][bias.length];
for (int i = 0; i < bias.length; ++i) {
derivatives[i][i] = scale[i];
// derivatives are computed with respect to the physical parameters,
// not with respect to the normalized parameters (normalization is
// performed later on), so the derivative is really 1.0 and not scale[i]
derivatives[i][i] = 1.0;
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment