Commit d3e568f9 authored by Luc Maisonobe's avatar Luc Maisonobe

Fixed findbugs warnings about serialization.

parent 69297350
......@@ -11,15 +11,20 @@
<Or>
<Class name="~.*\.DSSTPropagator\$MeanPlusShortPeriodicMapper\$DataTransferObject$" />
<Class name="~.*\.IntegratedEphemeris\$DataTransferObject$" />
<Class name="~.*\.KeplerianPropagator\$DataTransferObject$" />
<Class name="~.*\.EcksteinHechlerPropagator\$DataTransferObject$" />
</Or>
<Bug pattern="SE_BAD_FIELD" />
</Match>
<!-- the following classes are serialized using writeReplace/readResolve with proxy classes,
so the is no real problem about the base class not having a proper constructor.
This is tested in the IntegratedEphemerisTest for the ephemeris and both propagators. -->
so the is no real problem about the base class not having a proper constructor. -->
<Match>
<Or>
<Class name="~.*\.AbstractAnalyticalPropagator\$BoundedPropagatorView$" />
<Class name="~.*\.KeplerianPropagator$" />
<Class name="~.*\.EcksteinHechlerPropagator$" />
<Class name="~.*\.Ephemeris$" />
<Class name="~.*\.IntegratedEphemeris$" />
<Class name="~.*\.DSSTPropagator\$MeanPlusShortPeriodicMapper$" />
<Class name="~.*\.NumericalPropagator\$OsculatingMapper$" />
......@@ -27,20 +32,15 @@
<Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR" />
</Match>
<Match>
<Class name="~.*\.DSSTPropagator\$MeanPlusShortPeriodicMapper$" />
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
</Match>
<Match>
<Class name="~.*\.GeographicZoneDetector$" />
<Or>
<Class name="~.*\.DSSTPropagator\$MeanPlusShortPeriodicMapper$" />
<Class name="~.*\.FieldOfView$" />
<Class name="~.*\.FootprintOverlapDetector$" />
<Class name="~.*\.GeographicZoneDetector$" />
</Or>
<Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
</Match>
<!-- The following is an intentional behaviour, to be removed when class is suppressed -->
<Match>
<Class name="~.*\.SpacecraftFrame\$LocalProvider$"/>
<Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION" />
</Match>
<!-- the following are in fact false positives from findbugs -->
<!-- their occurrence depends on the java compiler used -->
<Match>
......
......@@ -90,7 +90,7 @@ public class EcksteinHechlerPropagator extends AbstractAnalyticalPropagator impl
private EHModel initialModel;
/** All models. */
private TimeSpanMap<EHModel> models;
private transient TimeSpanMap<EHModel> models;
/** Reference radius of the central body attraction model (m). */
private double referenceRadius;
......
......@@ -269,7 +269,10 @@ public class Ephemeris extends AbstractAnalyticalPropagator implements BoundedPr
}
/** Internal PVCoordinatesProvider for attitude computation. */
private static class LocalPVProvider implements PVCoordinatesProvider {
private static class LocalPVProvider implements PVCoordinatesProvider, Serializable {
/** Serializable UID. */
private static final long serialVersionUID = 20160115L;
/** Current state. */
private SpacecraftState currentState;
......
......@@ -47,7 +47,7 @@ public class KeplerianPropagator extends AbstractAnalyticalPropagator implements
private SpacecraftState initialState;
/** All states. */
private TimeSpanMap<SpacecraftState> states;
private transient TimeSpanMap<SpacecraftState> states;
/** Build a propagator from orbit only.
* <p>The central attraction coefficient μ is set to the same value used
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment