@MaximeJ - Thanks for the changes.
I should've been clearer: "The original purpose of the class modifications was to support the TDM ccsds..." but this purpose was then extended to include theoretical configurations from other potential observation file types.
The Transit time + Transmit receive apparent were included as "catch all" possibilities for Observation files, and are not in TDM files consistent with the latest TDM ccsds.
If we were to limit the scope of this change to just cover the TDM ccsds options, then we would not include these possibilities.
Happy to defer to you regarding the likelihood/usefulness of allowing these "MeasurementTimeTag" configurations. Maybe to get this over the line we could roll back and do Transmit + Receive for two-way observations only, meaning as a first pass we've supported the TDM ccsds?
@MaximeJ -
In response to: 1 . Will get back to you on that tomorrow. ICLA is obviously fine + I'll send that off now. 5 . Agreed that "MeasurementTimeTag" is a better name. 6 . If you have a specific test input/output in mind I'd be interested to see that working. 7 . Sounds good.
Will try to cast my mind back to the logic behind these decisions regarding the support choices for each timetag type:
I think both one way Range + Range Rate currently lack TX/Bounce correction support. The assumption being one-way classes are always time of reception. This maybe makes the Angular implementation inconsistent from an OREKIT perspective - the motivation to support these was trying to support different sensor techniques, although a year later I'm not totally sure it makes complete sense. There shouldn't have be any usage of TXRX in non angular classes (+ I can't see any?) An exception to handle this would be appropriate.
The original purpose of the class modifications was really to support the TDM ccsds, which is fairly vague about what combinations are possible - so I'm open to suggestions as to what cases are likely or useful and happy to remove/add different permutations.
Thanks all,
tommyfryer (30a5ad6c) at 03 Mar 15:15
[vary-obs-timetag] remove deprecation tag + unused non field method
[vary-obs-timetag] Adding variable time tag specifications to range and angles observation classes, allow for obs to be specified at transit/bounce and tx/transmit. Retain current behaviour as default.
In the case of angles measurements an additional transmit case is included where the estimated value is calculated either from a transmit apparent or a receive apparent station position, whilst the time tag still describes the transmit time.
tommyfryer (c89bf63a) at 16 Feb 16:40
[vary-obs-timetag] correct a comment to specify transmit receive ap...
tommyfryer (5155db53) at 16 Feb 16:15
[vary-obs-timetag] add transmit (receive apparent) time tag case an...
tommyfryer (ddc688b6) at 16 Feb 14:59
[vary-obs-timetag] amend checkstyle violations and improve commenting
tommyfryer (a1ad07dd) at 16 Feb 13:12
[vary-obs-timetag] more accurate description of shifted tolerance i...
... and 1 more commit
tommyfryer (8774ede6) at 16 Feb 11:48
[vary-obs-timetag] Add tests for obs estimation when state is not a...
tommyfryer (f48c6be3) at 15 Feb 19:37
[vary-obs-timetag] Add delta term for shifting transit states if st...
tommyfryer (6f55bc4c) at 15 Feb 18:50
[vary-obs-timetag] use relative position at obs epoch time for angu...
tommyfryer (3f231d0f) at 15 Feb 18:25
[vary-obs-timetag] checkstyle formatting
tommyfryer (a3dcf0c8) at 15 Feb 18:23
[vary-obs-timetag] add limiting constructors to Range and RangeRate...
tommyfryer (18b65790) at 14 Feb 10:04
[vary-obs-timetag] add test cases for angular measurement types
tommyfryer (0856809e) at 11 Feb 22:29
[vary-obs-timetag] Add angular observation implementation for varia...
tommyfryer (98f62e8a) at 10 Feb 16:19
[vary-obs-timetag] address checkstyle violations
tommyfryer (49232e9f) at 10 Feb 09:41
[vary-obs-timetag] change time of flight calculation name
... and 1 more commit
tommyfryer (3a6a4ea6) at 09 Feb 11:13
[vary-obs-timetag] range rate variable time tag specification test
... and 1 more commit
tommyfryer (75d86aac) at 08 Feb 22:11
[vary-obs-timetag] do not correct for time of flight relative movem...
tommyfryer (798a1ba9) at 08 Feb 21:39
[vary-obs-timetag] Working Range Rate implementation for variable t...