Ok, i wanted to at least mention it just in case.
Shouldn't we check that each class is at least covered at 95 % ?
Vincent CUCCHIETTI (e3110180) at 16 Mar 09:16
Fixed SonarQube warnings
Vincent CUCCHIETTI (c8293a62) at 15 Mar 13:26
Updated changes.xml for official release.
... and 12 more commits
Vincent CUCCHIETTI (ba2b909f) at 14 Mar 16:35
Updated changes.xml for official release.
... and 14 more commits
Hi all,
@MaximeJ noticed that the previously available constructor :
EphemerisPropagatorBuilder(List<SpacecraftState> states, int interpolationPoints, double extrapolationThreshold, AttitudeProvider attitudeProvider)
Is not available anymore after the interpolation refactoring (my bad again).
Should we include a fix for this in a patch or a minor release @bryan ?
Cheers, Vincent
Fix issue-1296: Make lazy loading of UTC thread safe by checking if already loaded inside synchronized block
Closes #1296
Unfortunatly he cannot add it as it is @guillermojanner. The code in your forum post use a proprietary method to convert Epoch to DateTime.
Could you perhaps try your test on your hand using this branch ?
Cheers, Vincent
Fix interpolation in Ephemeris when interpolationPoints=1. I.e. stepwise interpolations. Thanks to Sander Cochran for the failing test case.
Thank you very much Evan, the constructors you deprecated were there for coherence purposes with the previous versions but they are very prone to error indeed so you did well
I'm approving the MR
Hi @LordRaptor,
I only added one comment about the number of tests. Once this is taken into account, i will approve this MR.
Cheers, Vincent
Could you reduce the number of tests to 10 ? It fails quite easily so we don't need such a huge number of tests.
@Serrof Indeed, you will not have any guarantee but it is the best we can do we what we have. I used it for testing multithreading capability with interpolators.
Thank you for this fix @LordRaptor
Cheers, Vincent
Hi @evanward1 and thank you for this fix.
Could you also modify the AbstractFieldTimeInterpolator
? I will then approve this MR.
Cheers, Vincent
Hi @evanward1,
i see that you have assigned this issue to yoursel, are you already working on it ? Otherwise i can do it
Cheers, Vincent