Eclipse Detector: Re-add the getters and delete deprecated constructors ?
- Removed the getters for the occulted and occulting body;
- Lead to the deprecation of constructor based on a spherical occulting body.
For version 10.0 shall we ?
- Write back some getters. They can be useful when multiple EclipseDetectors are used and we want to discriminate between them.
Example: Set up 2 EclipseDetectors for Sun occultation, one with the Earth and the other one with the Moon as the occulting body.
Use an event logger to log the events.
After propagation, how can we distinguish between Earth eclipses and Moon eclipses if we don't have access to the occulting body name ?
Maybe there is another way to do it but I don't know how...
- Delete the deprecated constructors and the inner class
Though it seems ok to me to keep the older constructors for users that just want to use "simple" spherical-based occultation.
On the other hand we could simply document how to use a spherical body, as @luc explains it in issue #535 (closed).
What do you think ?
To upload designs, you'll need to enable LFS. More information