Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Orekit
Orekit
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 54
    • Issues 54
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 6
    • Merge Requests 6
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Orekit
  • OrekitOrekit
  • Issues
  • #560

Closed
Open
Opened Jun 12, 2019 by Maxime Journot@MaximeJDeveloper

New lines property in checkstyle.xml configuration file

In checkstyle.xml, I'd like to replace one of the last line:

<module name="NewlineAtEndOfFile">

With:

<module name="NewlineAtEndOfFile">
    <property name="lineSeparator" value="lf"/>
</module>

The reason is that I am using Windows operating system (I know...).
I configured my editor to use unix-style end of lines ("lf"), so that when I'm pushing code I'm not messing around the whole git.
However, my operating system being what it is, checkstyle wants to see "CR/LF" ends of line at the end of every java files. So it raises an error for all the files in src/main/java.
I've been using the property above for a while now. It works well and I think it could benefit to other developers that are also using Windows OS (if there is any...).

Do you think it's a good idea ?
I'm not sure whether it can have some side effects on Linux OS or on someone's repository who would have an IDE configured differently.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
10.1
Milestone
10.1
Assign milestone
Time tracking
None
Due date
None
Reference: orekit/orekit#560