Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Orekit Orekit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 105
    • Issues 105
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Orekit
  • OrekitOrekit
  • Merge requests
  • !188

Update time toString() methods

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Evan Ward requested to merge date-time-tostring-590-591-637-825 into develop Aug 19, 2021
  • Overview 8
  • Commits 13
  • Pipelines 6
  • Changes 47

Previously the DateTimeComponents, TimeComponents, and AbsoluteDate toString() methods did not include the UTC offset. UTC offset is part of TimeComponents and the method signature of some toString() methods so it's ommission did not accurately represent the data. In ISO 8601 if the UTC offset is missing then times are interpreted as local, which is not intended. Added methods for printing without the UTC offset as well. The AbsoluteDate.toString(TimeScale) and AbsoluteDate.toString() methods still do not print the UTC offset because many time scales have non-integer minute offsets to UTC which is not supported in ISO 8601.

Previously DateTimeComponents.toString() could not print times during leap seconds. Now it can.

Previously the DateTimeComponents and TimeComponents toString() methods could round up to invalid times when within 0.5 ms of the next minute. Now they do not round up because they print additional digits when necessary.

These are backwards incompatible changes.

Added DateTimeComponents.toString(int, int) for user controlled rounding.

Fixes #637, #590 (closed), #591 (closed), #825 (closed)

Edited Sep 01, 2021 by Evan Ward
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: date-time-tostring-590-591-637-825