Skip to content
Snippets Groups Projects
Commit 2352282b authored by Guylaine Prat's avatar Guylaine Prat
Browse files

Evolution of pom.xml (with change findbugs to spotbugs; issue in gitlab)

parent 91ff5264
No related branches found
No related tags found
No related merge requests found
...@@ -87,9 +87,19 @@ ...@@ -87,9 +87,19 @@
<property name="checkFormat" value="NoWhitespaceAfter"/> <property name="checkFormat" value="NoWhitespaceAfter"/>
</module> </module>
<module name="SuppressionCommentFilter"> <module name="SuppressionCommentFilter">
<property name="offCommentFormat" value="CHECKSTYLE\: stop FallThrough check"/> <property name="offCommentFormat" value="CHECKSTYLE\: stop Indentation check"/>
<property name="onCommentFormat" value="CHECKSTYLE\: resume FallThrough check"/> <property name="onCommentFormat" value="CHECKSTYLE\: resume Indentation check"/>
<property name="checkFormat" value="FallThrough"/> <property name="checkFormat" value="IndentationCheck"/>
</module>
<module name="SuppressionCommentFilter">
<property name="offCommentFormat" value="CHECKSTYLE\: stop MultipleStringLiterals check"/>
<property name="onCommentFormat" value="CHECKSTYLE\: resume MultipleStringLiterals check"/>
<property name="checkFormat" value="MultipleStringLiteralsCheck"/>
</module>
<module name="SuppressionCommentFilter">
<property name="offCommentFormat" value="CHECKSTYLE\: stop UnnecessaryParentheses check"/>
<property name="onCommentFormat" value="CHECKSTYLE\: resume UnnecessaryParentheses check"/>
<property name="checkFormat" value="UnnecessaryParentheses"/>
</module> </module>
</module> </module>
<module name="RegexpHeader"> <module name="RegexpHeader">
......
<?xml version="1.0"?>
<!--
This file contains some false positive bugs detected by findbugs. Their
false positive nature has been analyzed individually and they have been
put here to instruct findbugs it must ignore them.
-->
<FindBugsFilter>
</FindBugsFilter>
...@@ -18,32 +18,33 @@ ...@@ -18,32 +18,33 @@
<properties> <properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<rugged.findbugs-maven-plugin.version>3.0.4</rugged.findbugs-maven-plugin.version> <rugged.spotbugs-maven-plugin.version>3.1.7</rugged.spotbugs-maven-plugin.version>
<rugged.jacoco-maven-plugin.version>0.7.9</rugged.jacoco-maven-plugin.version> <rugged.jacoco-maven-plugin.version>0.8.2</rugged.jacoco-maven-plugin.version>
<rugged.maven-assembly-plugin.version>3.0.0</rugged.maven-assembly-plugin.version> <rugged.maven-assembly-plugin.version>3.1.0</rugged.maven-assembly-plugin.version>
<rugged.maven-bundle-plugin.version>3.3.0</rugged.maven-bundle-plugin.version> <rugged.maven-bundle-plugin.version>4.1.0</rugged.maven-bundle-plugin.version>
<rugged.maven-changes-plugin.version>2.12.1</rugged.maven-changes-plugin.version> <rugged.maven-changes-plugin.version>2.12.1</rugged.maven-changes-plugin.version>
<rugged.maven-checkstyle-plugin.version>2.17</rugged.maven-checkstyle-plugin.version> <rugged.maven-checkstyle-plugin.version>3.0.0</rugged.maven-checkstyle-plugin.version>
<rugged.checkstyle.version>8.10</rugged.checkstyle.version> <rugged.checkstyle.version>8.14</rugged.checkstyle.version>
<rugged.maven-clean-plugin.version>3.0.0</rugged.maven-clean-plugin.version> <rugged.maven-clean-plugin.version>3.1.0</rugged.maven-clean-plugin.version>
<rugged.maven-compiler-plugin.version>3.6.1</rugged.maven-compiler-plugin.version> <rugged.maven-compiler-plugin.version>3.8.0</rugged.maven-compiler-plugin.version>
<rugged.maven-javadoc-plugin.version>2.10.4</rugged.maven-javadoc-plugin.version> <rugged.maven-javadoc-plugin.version>3.0.1</rugged.maven-javadoc-plugin.version>
<rugged.maven-jar-plugin.version>3.0.2</rugged.maven-jar-plugin.version> <rugged.maven-jar-plugin.version>3.1.0</rugged.maven-jar-plugin.version>
<rugged.maven-jxr-plugin.version>2.5</rugged.maven-jxr-plugin.version> <rugged.maven-jxr-plugin.version>3.0.0</rugged.maven-jxr-plugin.version>
<rugged.plantuml-maven-plugin.version>1.2</rugged.plantuml-maven-plugin.version> <rugged.plantuml-maven-plugin.version>1.2</rugged.plantuml-maven-plugin.version>
<rugged.plantuml.version>1.2017.15</rugged.plantuml.version> <rugged.plantuml.version>1.2018.12</rugged.plantuml.version>
<rugged.maven-project-info-reports-plugin.version>2.9</rugged.maven-project-info-reports-plugin.version> <rugged.maven-project-info-reports-plugin.version>3.0.0</rugged.maven-project-info-reports-plugin.version>
<rugged.maven-resources-plugin.version>3.0.2</rugged.maven-resources-plugin.version> <rugged.maven-resources-plugin.version>3.1.0</rugged.maven-resources-plugin.version>
<rugged.maven-site-plugin.version>3.6</rugged.maven-site-plugin.version> <rugged.maven-site-plugin.version>3.7.1</rugged.maven-site-plugin.version>
<rugged.maven-surefire-plugin.version>2.20</rugged.maven-surefire-plugin.version> <rugged.maven-source-plugin.version>3.0.1</rugged.maven-source-plugin.version>
<rugged.maven-surefire-report-plugin.version>2.20</rugged.maven-surefire-report-plugin.version> <rugged.maven-surefire-plugin.version>2.22.1</rugged.maven-surefire-plugin.version>
<rugged.maven-surefire-report-plugin.version>2.22.1</rugged.maven-surefire-report-plugin.version>
<rugged.jgit.buildnumber.version>1.2.10</rugged.jgit.buildnumber.version> <rugged.jgit.buildnumber.version>1.2.10</rugged.jgit.buildnumber.version>
<rugged.build-helper-maven-plugin.version>3.0.0</rugged.build-helper-maven-plugin.version> <rugged.build-helper-maven-plugin.version>3.0.0</rugged.build-helper-maven-plugin.version>
<rugged.nexus-staging-maven-plugin.version>1.6.8</rugged.nexus-staging-maven-plugin.version> <rugged.nexus-staging-maven-plugin.version>1.6.8</rugged.nexus-staging-maven-plugin.version>
<rugged.maven-gpg-plugin.version>1.6</rugged.maven-gpg-plugin.version> <rugged.maven-gpg-plugin.version>1.6</rugged.maven-gpg-plugin.version>
<rugged.maven-install-plugin.version>2.5.2</rugged.maven-install-plugin.version> <rugged.maven-install-plugin.version>3.0.0-M1</rugged.maven-install-plugin.version>
<rugged.orekit.version>9.2</rugged.orekit.version> <rugged.orekit.version>9.3-SNAPSHOT</rugged.orekit.version>
<rugged.hipparchus.version>1.3</rugged.hipparchus.version> <rugged.hipparchus.version>1.4</rugged.hipparchus.version>
<rugged.junit.version>4.12</rugged.junit.version> <rugged.junit.version>4.12</rugged.junit.version>
<rugged.compiler.source>1.8</rugged.compiler.source> <rugged.compiler.source>1.8</rugged.compiler.source>
<rugged.compiler.target>1.8</rugged.compiler.target> <rugged.compiler.target>1.8</rugged.compiler.target>
...@@ -129,10 +130,10 @@ ...@@ -129,10 +130,10 @@
</scm> </scm>
<issueManagement> <issueManagement>
<system>Redmine</system> <system>Gitlab</system>
<url>https://www.orekit.org/forge/projects/rugged/issues</url> <url>https://gitlab.orekit.org/orekit/rugged/issues</url>
</issueManagement> </issueManagement>
<mailingLists> <mailingLists>
<mailingList> <mailingList>
<name>Shared Orekit/Rugged announces mailing list</name> <name>Shared Orekit/Rugged announces mailing list</name>
...@@ -448,14 +449,14 @@ ...@@ -448,14 +449,14 @@
<version>${rugged.maven-project-info-reports-plugin.version}</version> <version>${rugged.maven-project-info-reports-plugin.version}</version>
</plugin> </plugin>
<plugin> <plugin>
<groupId>org.codehaus.mojo</groupId> <groupId>com.github.spotbugs</groupId>
<artifactId>findbugs-maven-plugin</artifactId> <artifactId>spotbugs-maven-plugin</artifactId>
<version>${rugged.findbugs-maven-plugin.version}</version> <version>${rugged.spotbugs-maven-plugin.version}</version>
<configuration> <configuration>
<threshold>Normal</threshold> <threshold>Normal</threshold>
<effort>Default</effort> <effort>Default</effort>
<excludeFilterFile>${basedir}/findbugs-exclude-filter.xml</excludeFilterFile> <excludeFilterFile>${basedir}/spotbugs-exclude-filter.xml</excludeFilterFile>
</configuration> </configuration>
</plugin> </plugin>
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
...@@ -584,6 +585,21 @@ ...@@ -584,6 +585,21 @@
<id>release</id> <id>release</id>
<build> <build>
<plugins> <plugins>
<!--
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>${orekit.maven-source-plugin.version}</version>
<executions>
<execution>
<id>attach-sources</id>
<goals>
<goal>jar-no-fork</goal>
</goals>
</execution>
</executions>
</plugin>
-->
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId> <artifactId>maven-javadoc-plugin</artifactId>
......
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
<include>BUILDING.txt</include> <include>BUILDING.txt</include>
<include>pom.xml</include> <include>pom.xml</include>
<include>checkstyle.xml</include> <include>checkstyle.xml</include>
<include>findbugs-exclude-filter.xml</include> <include>spotbugs-exclude-filter.xml</include>
<include>license-header.txt</include> <include>license-header.txt</include>
</includes> </includes>
<useDefaultExcludes>true</useDefaultExcludes> <useDefaultExcludes>true</useDefaultExcludes>
...@@ -22,4 +22,4 @@ ...@@ -22,4 +22,4 @@
<useDefaultExcludes>true</useDefaultExcludes> <useDefaultExcludes>true</useDefaultExcludes>
</fileSet> </fileSet>
</fileSets> </fileSets>
</assembly> </assembly>
\ No newline at end of file
...@@ -58,7 +58,7 @@ with the following command: ...@@ -58,7 +58,7 @@ with the following command:
For other commands like generating the site, or generating the For other commands like generating the site, or generating the
[checkstyle](http://checkstyle.sourceforge.net/), [checkstyle](http://checkstyle.sourceforge.net/),
[findbugs](http://findbugs.sourceforge.net/) or [spotbugs](https://spotbugs.github.io/) or
[jacoco](http://www.eclemma.org/jacoco/) reports, see the maven [jacoco](http://www.eclemma.org/jacoco/) reports, see the maven
plugins documentation at [maven site](http://maven.apache.org/plugins/index.html). plugins documentation at [maven site](http://maven.apache.org/plugins/index.html).
......
...@@ -44,7 +44,7 @@ The second goal, robustness, has some specific implications for a low level ...@@ -44,7 +44,7 @@ The second goal, robustness, has some specific implications for a low level
component like Rugged. In some sense, it can be considered an extension of the component like Rugged. In some sense, it can be considered an extension of the
previous goal as it can also be improved by testing. It can also be improved previous goal as it can also be improved by testing. It can also be improved
by automatic checking tools that analyze either source code or binary code. The by automatic checking tools that analyze either source code or binary code. The
[findbugs](http://findbugs.sourceforge.net/) tool is already configured for [spotbugs](https://spotbugs.github.io/) tool is already configured for
automatic checks of the library using a maven plugin. automatic checks of the library using a maven plugin.
This is however not sufficient. A library is intended to be used by applications This is however not sufficient. A library is intended to be used by applications
...@@ -160,9 +160,9 @@ Design Rules ...@@ -160,9 +160,9 @@ Design Rules
seek for a line test coverage of at least 80% (more is better) seek for a line test coverage of at least 80% (more is better)
* *findbugs* (robustness) * *spotbugs* (robustness)
fix _all_ errors and warnings found by findbugs fix _all_ errors and warnings found by spotbugs
* *no runtime assumptions* (robustness) * *no runtime assumptions* (robustness)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment