Rugged 3 is not compatible with Orekit 12
I think one of the last issues to address before publishing Orekit Jpype to PyPi is Rugged: the current version (3.0) is not compatible with Orekit 12... orekit/rugged#395 I opened a merge request in the Rugged repo to fix that (orekit/rugged!8), hopefully it will be merged soon.
We could already publish Orekit jpype to PyPi with the current Orekit 12 and Rugged 3 JARs (so the Broken Rugged release), and then publish a new version of Orekit Jpype when a new Rugged release (containing the Orekit 12 compatibility fix) is available. But IMO it is nicer to publish a package which works completely, so here are two solution ideas (not incompatible, we could do both):
- When orekit/rugged!8 is merged, build the Rugged 4.0-SNAPSHOT JAR from Rugged's
develop
branch, copy it into this repo, and publish this version to PyPi as orekit_jpype 12.0.2 for instance. I already tested that in my private branchadd-rugged-tests
containing a new unit test for Rugged, it works (https://gitlab.orekit.org/Petrush/orekit_jpype/-/pipelines/5501) - Also publish a orekit_jpype 11.3.x version with the Orekit 11.3 and Rugged 3.0 JARs, which is the last Orekit version compatible with Rugged 3.0
Side note about JARs in this repo
In general, it would be nice to not maintain the Orekit&Rugged&Hipparchus JARs in this repo anymore, but to retrieve them from Maven automatically:
- for the PyPi wheel, this could be done before pushing the package to PyPi either manually or in the CI pipeline
- and for using Orekit_jpype from source (by using git clone or pip installing the git repo), it could be done via a post-checkout git hook.