Make rugged compatible with Orekit 12

This is an attempt at making Rugged compatible with Orekit 12 (addresses #395 (closed) ).

There are two things where I am not super sure:

• Some unit tests required higher error thresholds than before... The deviations were small but still higher than the old thresholds. I don't know Orekit enough to know what in Orekit 12 caused this deviations
• I tried to update the Gitlab CI configuration because I got this error because SonarQube was updated: https://gitlab.orekit.org/orekit/rugged/-/jobs/17122
  • I modified the pom.xml and .gitlab-ci.yml files to be more similar to the same files in the latest develop branch of the orekit repo. However, I didn't manage to make it work, I got an issue with the sonar login: https://gitlab.orekit.org/orekit/rugged/-/jobs/17128

mentioned in issue #395 (closed)

Hi @yzokras Thank you for attempting this !!

Some unit tests required higher error thresholds than before... The deviations were small but still higher than the old thresholds. I don't know Orekit enough to know what in Orekit 12 caused this deviations

Maybe @luc could answer you on this one but it seems that you had to increase the thresholds quite a lot indeed...

I tried to update the Gitlab CI configuration because I got this error because SonarQube was updated: https://gitlab.orekit.org/orekit/rugged/-/jobs/17122

• I modified the pom.xml and .gitlab-ci.yml files to be more similar to the same files in the latest develop branch of the orekit repo. However, I didn't manage to make it work, I got an issue with the sonar login: https://gitlab.orekit.org/orekit/rugged/-/jobs/17128

This one would be for @sdinot ;) (I'm useless). I think we need to create the Rugged project on the new Sonar before analyzing merge requests.

I guess the changes are good, but I am not in charge of Rugged anymore, so cannot really decide anything about it. Perhaps @jguinet would have an opinion about that.

Hi @yzokras, thanks for your work,

I m going (next week) to take a look about the slight numerical changes, which seems to be insignificant

mentioned in issue Petrush/orekit_jpype#6

added 16 commits

• f53a7c55...e53aec7f - 7 commits from branch develop
• ffd79eec - bump orekit version to 12.0.2
• 23d7a353 - add valueSpanMapChanged​ method added to ParameterObserver in Orekit 12
• 0e260d75 - use new PV and angular hermite interpolators
• e659b0a6 - Rename PositionAngle -> PositionAngleType
• 8cc9178e - increase some test thresholds, no idea why...
• 69acf7c9 - pom.xml: bump plugin versions to same versions as orekit repo
• 20608608 - update changelog for update to orekit 12
• fbcafb34 - pom.xml: add Clement Jonglez to contributors
• 6b403014 - update rugged architecture diagram: orekit>=12.0, hipparchus>=3.0

Compare with previous version

marked this merge request as draft

I got an email saying that merging is not possible anymore because of conflicts. I am rebasing my branch and fixing the checkstyle warnings, I will reopen the merge request soon

added 1 commit

• f998052c - fix checkstyle warnings

Compare with previous version

added 13 commits

• f998052c...691761ff - 3 commits from branch develop
• b95d5b2f - bump orekit version to 12.0.2
• 079115a6 - add valueSpanMapChanged​ method added to ParameterObserver in Orekit 12
• 5e814398 - use new PV and angular hermite interpolators
• 9a6d4c4b - Rename PositionAngle -> PositionAngleType
• cfbf9225 - increase some test thresholds, no idea why...
• 0edf65a3 - pom.xml: bump plugin versions to same versions as orekit repo
• 56d3277d - update changelog for update to orekit 12
• a7486714 - pom.xml: add Clement Jonglez to contributors
• 9fbf1370 - update rugged architecture diagram: orekit>=12.0, hipparchus>=3.0
• e29de162 - fix checkstyle warnings

Compare with previous version

marked this merge request as ready

marked this merge request as draft

added 12 commits

• e29de162...92ff0747 - 2 commits from branch develop
• f47e8cdf - bump orekit version to 12.0.2
• 974a6d5e - add valueSpanMapChanged​ method added to ParameterObserver in Orekit 12
• e2621325 - use new PV and angular hermite interpolators
• 0c9e840d - Rename PositionAngle -> PositionAngleType
• ac390fa2 - increase some test thresholds, no idea why...
• 805a1120 - pom.xml: bump plugin versions to same versions as orekit repo
• de6b2b09 - update changelog for update to orekit 12
• a1a874aa - pom.xml: add Clement Jonglez to contributors
• 81d93b80 - update rugged architecture diagram: orekit>=12.0, hipparchus>=3.0
• a306aaea - fix checkstyle warnings

Compare with previous version

marked this merge request as ready

Thanks for fixing the CI pipeline (!11 (merged)), I rebased onto the latest develop and force-pushed.

there are still some javadoc problems with HTML5 in develop pipeline , I try to correct them :

https://gitlab.orekit.org/orekit/rugged/-/jobs/17322

added 1 commit

• 399f7d0c - pom.xml: bump plantuml to 1.2024.5

Compare with previous version

added 13 commits

• 399f7d0c...c92d7b4d - 2 commits from branch develop
• cd3561b1 - 1 earlier commit
• eee53842 - add valueSpanMapChanged​ method added to ParameterObserver in Orekit 12
• 8b775724 - use new PV and angular hermite interpolators
• da2bb8d5 - Rename PositionAngle -> PositionAngleType
• d3e57929 - increase some test thresholds, no idea why...
• 40ecf28a - pom.xml: bump plugin versions to same versions as orekit repo
• 1397ab2a - update changelog for update to orekit 12
• 16e5d382 - pom.xml: add Clement Jonglez to contributors
• e2f89fa4 - update rugged architecture diagram: orekit>=12.0, hipparchus>=3.0
• 5e7df560 - fix checkstyle warnings
• 7d309afb - pom.xml: bump plantuml to 1.2024.5

Compare with previous version

Rebased on latest develop following !12 (merged) .

requested review from @jguinet

assigned to @yzokras

resolved all threads

approved this merge request

mentioned in commit a6d7a373

merged